Build with NDEBUG again

Bug #1841412 reported by Timo Aaltonen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mesa (Ubuntu)
Invalid
Undecided
Unassigned
Bionic
Fix Released
Undecided
Timo Aaltonen

Bug Description

[Impact]
Mesa is now built with meson, and it turns out that meson < 0.47.0 (commit 7c4736d27f4c5d7 to be exact) doesn't handle command line options properly which means that -Db_ndebug=true didn't have any effect when mesa is built on bionic. This means that some asserts are enabled, and at least nouveau is affected.

[Test case]
chech the build log that -DNDEBUG is passed

[Regression potential]
none really, it just adds a build flag which should've been there

Timo Aaltonen (tjaalton)
Changed in mesa (Ubuntu):
status: New → Invalid
Changed in mesa (Ubuntu Bionic):
assignee: nobody → Timo Aaltonen (tjaalton)
status: New → Confirmed
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Timo, or anyone else affected,

Accepted mesa into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mesa/19.0.8-0ubuntu0~18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in mesa (Ubuntu Bionic):
status: Confirmed → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (mesa/19.0.8-0ubuntu0~18.04.2)

All autopkgtests for the newly accepted mesa (19.0.8-0ubuntu0~18.04.2) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

vtk6/unknown (armhf)
kf5-messagelib/4:17.12.3-0ubuntu3 (armhf)
firefox/68.0.2+build1-0ubuntu0.18.04.1 (armhf)
openjdk-8/8u222-b10-1ubuntu1~18.04.1 (i386, s390x, arm64, armhf, ppc64el, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#mesa

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Timo Aaltonen (tjaalton) wrote :
tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mesa - 19.0.8-0ubuntu0~18.04.2

---------------
mesa (19.0.8-0ubuntu0~18.04.2) bionic; urgency=medium

  * i965-revert-enabling-softpin.diff: Dropped, unnecessary by now and
    broke Ice Lake which needs softpin. (LP: #1815172)
  * rules: Force -DNDEBUG, meson < 0.47 is buggy and doesn't set it even
    if we have b_ndebug=true. (LP: #1841412)

 -- Timo Aaltonen <email address hidden> Tue, 27 Aug 2019 09:42:44 +0300

Changed in mesa (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for mesa has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.