action.hold_request_permit_test should consult proximity adjustments

The top commit of the branch at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1841974-calc-prox-for-age-protect implements this request by refactoring the proximity adjustment calculation code so we can call it from more places. In this case, from the hold permit test when a particular (new) YAOUS is in place and set to true. The decision about whether to use adjusted or baseline proximity is left to the item's circulating library.

Noting that per earlier conversation, the language for the YAOUS "Use calculated proximity for age-protection test" and "When testing whether a copy is viable for a hold based on transit distance, use calculated proximity with adjustments rather than baseline Org Unit proximity" might be more clear if "check/checking" were used instead of "test/testing"

If test/testing is the general language that everyone's familiar in this particular area, I won't die on this hill, but from an end user perspective I think "check" is more clear.

I have tested the fix. My library can now put age-protected items on hold from the other library and have them delivered to us (and vice-versa). This is an important fix for our patrons, and will allow us to share our collections fully, per our agreement with the other library. This fix allows the libraries to share their collections while remaining separate entities in the Evergreen hierarchy, which makes it easier for patrons and the library staff for a variety of reasons.

I've pushed a rebased and terminology-adjusted branch up to the same location.

I have tested this code and consent to signing off on it with my name, Diane Disbro, and my email address, <email address hidden>.

I have tested this code and consent to signing off on it with my name, Nelson Appell, and my email address, <email address hidden>.

Pushed to master with minor corrections for inclusion in 3.6; thanks Mike, Diane, and Nelson!