Booking refresh follow up work

Bug #1843938 reported by Jane Sandberg
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Galen and Christine have pointed out some follow up work needed for the Booking refresh project. This follow up work is available at collab/sandbergja/lp1816475_booking_followup

Here are the remaining issues not yet addressed by that branch:

* create reservation: date input oddly formatted (I think that this is due to a material icon's spacing misbehaving)
* Create reservation: It's possible to easily (accidentally?) create a reservation in a past. It says "booking created" but the booking is not visible anywhere. This is problematic as you might mistakenly use the wrong day by mistake and not realize, and then you won't realize the booking is gone and/or you can't edit it.
* why does switching to the booking Angular app appear to cause a full refresh?
* booking pull list: formatting of timestamps isn't localized
* patron barcode input should ignore trailing whitespace

Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Revision history for this message
Jane Sandberg (sandbergja) wrote :

A note: I figured out why switching to the booking Angular app appears to cause a full refresh. I threw that fix onto the collab/sandbergja/lp1816475_booking_followup branch

Revision history for this message
Jane Sandberg (sandbergja) wrote :

And another note: the date-select and datetime-select were using a material icon that messed up the buttons when served locally. I swapped it out for another icon that works better, and that's now also in that branch.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

And another commit to ignore trailing whitespace in patron barcode fields

Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Jane Sandberg (sandbergja) wrote :

I added another commit to fix the unlocalized datetimes in the pull list.

The only item left is to add some validation to make sure that users don't create booking reservations in the past.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Validation added. All improvements available at collab/sandbergja/lp1816475_booking_followup

I believe this resolves all of the issues with the booking refresh from the 3.4 beta. Happy testing!

tags: added: pullrequest
Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

I've signed off on the current branch and pushed user/gmcharlt/lp1816475_booking_followup_signoff. My signoff branch includes a follow-up to align the start-time-after-end-time alert with the inputs for a (to me) cleaner appearance.

I see a couple issues with the presentation of form validation issues in the create reservation dialog, but they don't need to hold up this particular bug:

- the green bar that displays on the left side of the datetime inputs when a value is supplied (matching the required attribute) can be misleading if the value supplied is invalid (e.g., is in the past)
- datetime-select validation alerts are displayed only in the drop-down widget; perhaps they should be displayed before the datetime input for greater visibility

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_3_4. Thanks, Jane!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.