In Eoan, link_in_boot is the default, yet curtin still generates kernel-img.conf

Bug #1847257 reported by Dimitri John Ledkov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
subiquity
Fix Released
Undecided
Unassigned
curtin (Ubuntu)
Fix Released
High
Unassigned

Bug Description

In Eoan, link_in_boot is the default, yet curtin still generates kernel-img.conf

https://launchpad.net/ubuntu/+source/base-installer/1.158ubuntu5
https://launchpad.net/ubuntu/+source/linux-base/4.5ubuntu2

With this upload we have changed the default to be link_in_boot = yes, to be the default, without /etc/kernel-img.conf installed anymore.

Curtin should stop installing kernel-img.conf for Eoan and later.

Related branches

description: updated
Revision history for this message
Ryan Harper (raharper) wrote :

commit 08bf6ff7c6dd919bb420f610d2b427ce161d6096
Author: Dimitri John Ledkov <email address hidden>
Date: Thu Apr 11 18:29:03 2019 +0000

    Setup kernel-img.conf like base-installer/live-installer did.

    LP: #1534162

Should we remove it entirely, or only on target_release E and newer?

Or can we tell whether we should or should not?

Changed in curtin (Ubuntu):
importance: Undecided → High
status: New → Incomplete
Revision history for this message
Dan Watkins (oddbloke) wrote :

(Dropped the curtin task so we're only tracking status in one place for now.)

Ryan, is this really Incomplete given "Curtin should stop installing kernel-img.conf for Eoan and later" is in the bug description?

no longer affects: curtin
Revision history for this message
Ryan Harper (raharper) wrote :

@Dan Thanks for reading closer that I did.

Changed in curtin (Ubuntu):
status: Incomplete → Triaged
Ryan Harper (raharper)
Changed in curtin (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

This bug is fixed with commit 1fbf7d88 to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=1fbf7d88

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package curtin - 19.2-44-g8e618b34-0ubuntu1

---------------
curtin (19.2-44-g8e618b34-0ubuntu1) focal; urgency=medium

  * New upstream snapshot.
    - t/jenkins-runner: replace $EPOCHSECONDS with 'date +%s' [Paride Legovini]
    - curthooks: skip setup_kernel_img_conf on eoan and newer (LP: #1847257)
    - block_meta: use lookup for wwn, fix fallback from wwn, serial, path
      (LP: #1849322)
    - vmtest: Adjust TestScsiBasic to use dnames to find correct disk
    - schema: Add ptable value 'unsupported' (LP: #1848535)
    - tools/xkvm: add -nographic to speed up devopt query
    - test_block_dasd: fix random_device_id to only generate valid IDs
      (LP: #1849549)
    - vmtest: update skip_if_arch message
    - Add skip_by_date to eoan ipv6 vlan test
    - storage_config: interpret value, not presence, of
      DM_MULTIPATH_DEVICE_PATH [Michael Hudson-Doyle]
    - vmtest: Add skip_by_date for test_ip_output on eoan + vlans
    - block-schema: update raid schema for preserve and metadata
    - dasd: update partition table value to 'vtoc' (LP: #1847073)
    - clear-holders: increase the level for devices with holders by one
      (LP: #1844543)
    - tests: mock timestamp used in collect-log file creation (LP: #1847138)
    - ChrootableTarget: mount /run to resolve lvm/mdadm issues which
      require it.
    - block-discover: handle multipath disks (LP: #1839915)
    - Handle partial raid on partitions (LP: #1835091)
    - install: export zpools if present in the storage-config (LP: #1838278)
    - block-schema: allow 'mac' as partition table type (LP: #1845611)
    - jenkins-runner: disable the lockfile timeout by default [Paride Legovini]
    - curthooks: use correct grub-efi package name on i386 (LP: #1845914)
    - vmtest-sync-images: remove unused imports [Paride Legovini]
    - vmtests: use file locking on the images [Paride Legovini]
    - vmtest: enable arm64 [Paride Legovini]
    - Make the vmtests/test_basic test suite run on ppc64el [Paride Legovini]
    - vmtests: separate arch and target_arch in tests [Paride Legovini]
    - vmtests: new decorator: skip_if_arch [Paride Legovini]
    - vmtests: increase the VM memory for Bionic
    - vmtests: Skip Eoan ZFS Root tests until bug fix is complete
    - Merge branch 'fix_merge_conflicts'
    - util: add support for 'tbz', 'txz' tar format types to sanitize_source
      (LP: #1843266)
    - net: ensure eni helper tools install if given netplan config
      (LP: #1834751)
    - d/control: update Depends for new probert package names
      [Dimitri John Ledkov]

 -- Ryan Harper <email address hidden> Fri, 01 Nov 2019 14:06:13 -0500

Changed in curtin (Ubuntu):
status: In Progress → Fix Released
Changed in subiquity:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.