Only mention ssphp needs updating if installed
Bug #1847345 reported by
Robert Lyon
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
High
|
Unassigned | ||
| 18.10 |
Fix Released
|
High
|
Unassigned | ||
| 19.04 |
Fix Released
|
High
|
Unassigned | ||
Bug Description
When we move to v1.17.6 some of the classes are different and so we need to warn user to upgrade the ssphp.
But we don't need to do the warning if ssphp is not installed
Revision history for this message
| Robert Lyon (robertl-9) wrote | #1 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #2 |
| Changed in mahara: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| milestone: | none → 19.10.0 |
Revision history for this message
| Kristina Hoeppner (kris-hoeppner) wrote | #3 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #4 |
| Changed in mahara: | |
| status: | In Progress → Fix Committed |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #5 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote | #6 |
| no longer affects: | mahara/19.10 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #7 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote | #8 |
To post a comment you must log in.
To test this
1)
- have 19.04 site
- run: make cleanssphp && ssphp
(to get rid of and then install ssphp)
- then upgrade to patch - should see the warning message about needing to upgrade ssphp
2)
- have 19.04 site
- run: make cleanssphp
(to get rid of ssphp)
- then upgrade to patch - should NOT see the warning message about needing to upgrade ssphp