Backport MPLS patches from 5.3 to 4.15

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1851446

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Hi Jeff,

can you give this Bionic kernel a try:
https://people.canonical.com/~phlin/kernel/lp-1851446-MPLS/

Thanks!

Thanks Sam! I'll pass that along and have them test these to ensure it works.

I can't add a task for Disco but Terry tells me that we need that as well. I validated that the patches were landed in 5.3, I do not believe they are in 5.0, so we'll probably need test kernels built for Disco as well.

Hi Jeff.
Unfortunately, was missing patch [1] that add the expose the support in the mlx5 driver.

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.5-rc2&id=5dc9520bf04a6b95660a307d7654460d1463d91a

could you please add it ?

Yours,
Talat

5dc9520b has landed in Eoan / Focal.

Please give the following B/D kernel a try:
https://people.canonical.com/~phlin/kernel/lp-1851446-MPLS/

They both contains:
  * 5dc9520b (net/mlx5e: Report netdevice MPLS features)
  * 8b6912a5 (net: vlan: Inherit MPLS features from parent device)
  * 2e770b50 (net: bonding: Inherit MPLS features from slave devices)

Commit 600bb0318c18e9616d97ad123caaa7c5f7bf222c is a merge for the 2 commits above, and thus ignored.

Sam, can you provide a link to your git tree with these commits?

On 1/30/20 7:37 AM, Jeff Lane wrote:
> Sam, can you provide a link to your git tree with these commits?
>

Thanks Jeff,

I'll get these on the notice board.. BTW, 4.15 is a long way back and I
cannot guarantee we can do this without issue. JFYI.

--
Terry

Sam, could you please provide a link to your git tree with these commits? The testers ran into issues with MPLS offloads and are asking for a source code link to debug their issues.

Hi Jeff,
sorry I didn't catch this reply in time,

I have no longer have git trees for them, the Bionic kernel was built with 4.15.0-74.84 with these patches applied, Disco with patches on 5.0.0-38.41 back then.

I can build a new one with the latest code and with git trees uploaded. Stayed tuned.

Hi Jeff,
here is the latest build for B/D
https://people.canonical.com/~phlin/kernel/lp-1851446-MPLS-0212/

And git trees:
https://code.launchpad.net/~cypressyew/+git/MPLS-ubuntu-bionic
https://code.launchpad.net/~cypressyew/+git/MPLS-ubuntu-disco

Thanks!

Hi,
I apologize for the delay in responding.

actually we tested the patches and it seems that some functionality of the features is not working as expected in Bionic/Eoan Kernels.

there is no TSO over MPLS traffic and that because of missing the following upstream patch:
- e4683f35f8e5 ("net/mlx5e: Move to HW checksumming advertising").

so we need also this patch to be able to use TSO for MPLS traffic.

if you please can backport it that will be great. and please let us know if you need any assistance.

Regards,
Mohammad

Hello Mohammad,

As you mentioned Bionic and Eoan here, do you still this patchset for Disco 5.0 kernel?
Thanks

Hi,
my fault, sorry.
i meant Disco and not Eoan.
Eoan already has the MPLS feature support.

yes we need this path to both Bionic/Disco

Hello Mohammad,
please give these 2 kernels a try:
https://people.canonical.com/~phlin/kernel/lp-1851446-MPLS-0407/

Note that these 2 kernels were built upon the tree in comment #11, the version might be fall behind the current kernel in -updates, you might need to boot to these manually.

Hi,
we tested it, the feature works completely fine.
So this kernel approved by our QA.

Thank you all for your efforts.

https://lists.ubuntu.com/archives/kernel-team/2020-April/108846.html

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

@Mohammed: Can you also test the official build and set the verification tag as appropriate per comment #18?

Hi,
looks that everything works fine, I added verification done tag.
Thank you all for your big efforts.

This bug was fixed in the package linux - 4.15.0-101.102

---------------
linux (4.15.0-101.102) bionic; urgency=medium

  * bionic/linux: 4.15.0-101.102 -proposed tracker (LP: #1877262)

  * 4.15.0-100.101 breaks userspace builds due to a bug in the headers
    /usr/include/linux/swab.h of linux-libc-dev (LP: #1877123)
    - include/uapi/linux/swab.h: fix userspace breakage, use __BITS_PER_LONG for
      swap

  * bionic snapdragon 4.15 snap failed Certification testing (LP: #1877657)
    - Revert "drm/msm: Use the correct dma_sync calls in msm_gem"
    - Revert "drm/msm: stop abusing dma_map/unmap for cache"

linux (4.15.0-100.101) bionic; urgency=medium

  * bionic/linux: 4.15.0-100.101 -proposed tracker (LP: #1875878)

  * built-using constraints preventing uploads (LP: #1875601)
    - temporarily drop Built-Using data

  * Add debian/rules targets to compile/run kernel selftests (LP: #1874286)
    - [Packaging] add support to compile/run selftests

  * getitimer returns it_value=0 erroneously (LP: #1349028)
    - [Config] CONTEXT_TRACKING_FORCE policy should be unset

  * QEMU/KVM display is garbled when booting from kernel EFI stub due to missing
    bochs-drm module (LP: #1872863)
    - [Config] Enable CONFIG_DRM_BOCHS as module for all archs

  * Backport MPLS patches from 5.3 to 4.15 (LP: #1851446)
    - net/mlx5e: Report netdevice MPLS features
    - net: vlan: Inherit MPLS features from parent device
    - net: bonding: Inherit MPLS features from slave devices
    - net/mlx5e: Move to HW checksumming advertising

  * LIO hanging in iscsit_free_session and iscsit_stop_session (LP: #1871688)
    - scsi: target: remove boilerplate code
    - scsi: target: fix hang when multiple threads try to destroy the same iscsi
      session
    - scsi: target: iscsi: calling iscsit_stop_session() inside
      iscsit_close_session() has no effect

  * Add hw timestamps to received skbs in peak_canfd (LP: #1874124)
    - can: peak_canfd: provide hw timestamps in rx skbs

  * Bionic update: upstream stable patchset 2020-04-23 (LP: #1874502)
    - ARM: dts: sun8i-a83t-tbs-a711: HM5065 doesn't like such a high voltage
    - bus: sunxi-rsb: Return correct data when mixing 16-bit and 8-bit reads
    - net: vxge: fix wrong __VA_ARGS__ usage
    - hinic: fix a bug of waitting for IO stopped
    - hinic: fix wrong para of wait_for_completion_timeout
    - cxgb4/ptp: pass the sign of offset delta in FW CMD
    - qlcnic: Fix bad kzalloc null test
    - i2c: st: fix missing struct parameter description
    - firmware: arm_sdei: fix double-lock on hibernate with shared events
    - null_blk: Fix the null_add_dev() error path
    - null_blk: Handle null_add_dev() failures properly
    - null_blk: fix spurious IO errors after failed past-wp access
    - xhci: bail out early if driver can't accress host in resume
    - x86: Don't let pgprot_modify() change the page encryption bit
    - block: keep bdi->io_pages in sync with max_sectors_kb for stacked devices
    - irqchip/versatile-fpga: Handle chained IRQs properly
    - sched: Avoid scale real weight down to zero
    - selftests/x86/ptrace_syscall_32: Fix no-vDSO segfault
    - PCI/switchtec: Fix init_completio...