Library upgrade: jTLine needs updating to fix jquery deprecations

Bug #1853230 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Rebecca Blundell

Bug Description

While working on: https://bugs.launchpad.net/mahara/+bug/1843357

I found jTLine has a deprecated jQuery selector. We could fix this manually or update the library.

The latest version of the file we use (https://github.com/naadydev/jTLine/blob/master/js/jtline.js) doesn't contain the deprecation, so it would make sense to grab that as long as it still works with the rest of Mahara. The only reason I would hesitate is that it doesn't look like an actively maintained library, so if it requires re-work on the Mahara side, it might not be worth our while.

Revision history for this message
Robert Lyon (robertl-9) wrote :

I believe wee ended up making a bunch of changes to that file and so therefore could consider it being 'forked' - it would be good to check through the changes to that file since we added our version to Mahara and see what things should be fixed on our one - rather than swapping our version for this newer one

Changed in mahara:
milestone: none → 20.04.0
importance: Undecided → Medium
status: New → Confirmed
Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10755

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10755
Committed: https://git.mahara.org/mahara/mahara/commit/911724f5fc3b3b71b7695ecdacd57dc8527a2fde
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 911724f5fc3b3b71b7695ecdacd57dc8527a2fde
Author: Rebecca Blundell <email address hidden>
Date: Tue Feb 11 16:49:08 2020 +1300

Bug 1853230: Fix jTLine jquery deprecation

Not fixed upstream
Library looks un-maintained

Change-Id: I7431ac7fe9099a9af900e547ad585ce0418f02e7

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.