Ubuntu
nemo package

Removal of a drive closes all windows and stops file transfers

Bug #1861968 reported by Baruch Youssin
54
This bug affects 7 people
Affects Status Importance Assigned to Milestone
nemo (Ubuntu)
Fix Released
Medium
Unassigned
Bionic
Fix Released
Medium
Fantu
Focal
Fix Released
Medium
Fantu

Bug Description

[Impact]
There are some cases where nemo crash on umount for example https://bugs.launchpad.net/ubuntu/+source/nemo/+bug/1861968
this has occurred and has been reported by many users (even outside of here)
I also had this issue and like other users before know it is cause the fails of files copy running in another nemo window.
In case of some operation like copy it is significant, even more so with cutting operations.
This is solved by upstream patch https://github.com/linuxmint/nemo/commit/4ffea61b26033da1305ab8287058044065a1c101 in nemo 4.0.0 and also backported in 3.8.6.

I included also a small patch that solves another crash case (https://github.com/linuxmint/nemo/issues/2248):
https://github.com/linuxmint/nemo/commit/b19f8d2e60df82628bbf609522a6a5b20fa4e72c
Applied upstream in nemo 4.6.0

[Test Case]
(Bionic only) For the crash on umount, simply umount something from nemo and nemo will crash (closing also any operation, like copy/cut running in it).

(Bionic + Focal) For the second patch keep mouse clicked when rename file/folder and press enter and nemo will crash.

[Where problems could occur]
The first patch about the crash on umount is easy to reproduce, many users already reported it after it caused problems with ongoing operations.
Patch is upstream for over 2 years and I have not found regressions about it from a fast search.

The second patch is rarer to happen but in some cases doing some operations quickly could happen so it seems useful to backport this too as it is a small patch with minimal impact and used upstream for a year already.

[Original description]

When I ask nemo to safely remove a drive, it closes all its windows, including those open on other drives, and aborts all file transfers on other drives.

Expected: when I ask to remove a drive safely, all nemo windows that are open on other drives, remain open and all transfers that do not involve the drive I want to remove, continue.

Instead: all windows closed and transfers aborted.

Package: nemo

lsb_release -rd
Description: Ubuntu 18.04.3 LTS
Release: 18.04

apt-cache policy nemo
nemo:
  Installed: 3.6.5-1
  Candidate: 3.6.5-1
  Version table:
 *** 3.6.5-1 500
        500 http://mirror.isoc.org.il/pub/ubuntu bionic/universe amd64 Packages
        100 /var/lib/dpkg/status

See original description
Revision history for this message
Fantu (fantonifabio) wrote :

this should be solved with this patch:
https://github.com/linuxmint/nemo/commit/4ffea61b26033da1305ab8287058044065a1c101
in nemo 3.8.6

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in nemo (Ubuntu):
status: New → Confirmed
Mathew Hodson (mhodson)
Changed in nemo (Ubuntu):
importance: Undecided → Medium
Changed in nemo (Ubuntu Bionic):
importance: Undecided → Medium
Revision history for this message
Mathew Hodson (mhodson) wrote :

The upstream fix is included in Ubuntu Eoan and later.
---

nemo (4.0.6-1) unstable; urgency=medium

  [ Norbert Preining ]
  * New upstream release (4.0.{4,6}).

  [ Maximiliano Curia ]
  * Add a basic gbp.conf
  * Add a debian/salsa-ci.yml file
  * Update symbols file
  * Release to unstable

 -- Maximiliano Curia <email address hidden> Thu, 29 Aug 2019 12:04:52 -0300

Changed in nemo (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Mathew Hodson (mhodson) wrote :

Adding patch from Fabio Fantoni in bug #1903451

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in nemo (Ubuntu Bionic):
status: New → Confirmed
Mathew Hodson (mhodson)
tags: added: bionic patch
Revision history for this message
Iain Lane (laney) wrote :

Patches for bionic and focal are in the queue now, they just need reviewing by the SRU team.

It's kind of two-bugs-in-one, but I hope that's OK. I didn't want to ask Fantu, a new contributor, to do a lot of work to split the bugs.

description: updated
Changed in nemo (Ubuntu Focal):
status: New → In Progress
Changed in nemo (Ubuntu Bionic):
status: Confirmed → In Progress
assignee: nobody → Fantu (fantonifabio)
Changed in nemo (Ubuntu Focal):
assignee: nobody → Fantu (fantonifabio)
description: updated
Mathew Hodson (mhodson)
Changed in nemo (Ubuntu Focal):
importance: Undecided → Medium
Revision history for this message
Mathew Hodson (mhodson) wrote :

The crash in Focal was also reported in bug 1915084 with a patch. I think it would be good to keep the two bugs separate and list them separately in the changelog.

Revision history for this message
Fantu (fantonifabio) wrote :

at the moment I see that the uploads are still pending...after 4 months from when the build about this was prepared and tested in bionic

https://launchpad.net/ubuntu/bionic/+queue?queue_state=1
https://launchpad.net/ubuntu/focal/+queue?queue_state=1

also seeing https://bugs.launchpad.net/ubuntu/+source/caribou/+bug/1912060

at the moment trying to do even just few important fixes (simply use of patches already made and tested/used elsewhere) on ubuntu always a long and very time-consuming undertaking without any result, I am now losing hope :(

Revision history for this message
Joshua Peisach (itzswirlz) wrote :

Fantu, it normally takes time. It always takes a week for -proposed to be pushed to -updates normally.

Revision history for this message
Fantu (fantonifabio) wrote :

ok that should be before in -proposed and can take weeks to reach -updates (more check and less risk, is ok), but this and caribou issue that is worse (in addition to causing crashes also causes a security issue) after long time are still not reached -proposed

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Baruch, or anyone else affected,

Accepted nemo into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nemo/4.4.2-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in nemo (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Changed in nemo (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Baruch, or anyone else affected,

Accepted nemo into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nemo/3.6.5-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Fantu (fantonifabio) wrote :

I did a test of focal proposed build and seems ok (I'm unable to reproduce the issue).
About bionic I already used a build with same patch for months (https://launchpad.net/~fantonifabio/+archive/ubuntu/ubuntu-fixes), I already tried to reproduce the crashes in november, not reproduced anymore and no regression found, if nobody will do other tests and other tests is needed I'll try the bionic proposed build (even should be equal)

Brian Murray (brian-murray)
tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nemo - 4.4.2-2ubuntu1

---------------
nemo (4.4.2-2ubuntu1) focal; urgency=medium

  [ Fabio Fantoni ]
  * backports a patch to fix a crash:
    - nemo-icon-container.c: clear any existing drag info when the
      icon view's location changes (LP: #1861968)

 -- Iain Lane <email address hidden> Wed, 27 Jan 2021 18:11:55 +0000

Changed in nemo (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for nemo has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Fantu (fantonifabio) wrote :

I installed nemo from -proposed in bionic and retested it, I was unable to reproduce the crash (of the issues solved by this version).

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nemo - 3.6.5-1ubuntu1

---------------
nemo (3.6.5-1ubuntu1) bionic; urgency=medium

  * backports patches for fix some crashes:
    - nemo-places-sidebar.c: Fix a few issues with mounting/ejecting
      (LP: #1861968)
    - nemo-icon-container.c: clear any existing drag info when the
      icon view's location changes

 -- Fabio Fantoni <email address hidden> Sun, 08 Nov 2020 15:20:03 +0100

Changed in nemo (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.