[UBUNTU 20.04] virtio-blk disks can go dissfunctional when swiotlb fills up

Bug #1867109 reported by bugproxy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Ubuntu-power-systems project
Fix Released
Critical
Frank Heimes
linux (Ubuntu)
Fix Released
Undecided
Frank Heimes

Bug Description

virtio-blk disks can go dissfunctional when swiotlb fills up
virtio-blk hw queue gets possibly permanently stopped when swiotlb full

For example, with a PV guest choose a small swiotlb (30MB) and create IO load on several virtio-blk disks simultaneously. It actually should not matter what causes the swiotlb pressure (can be virtio-net as well).

Fixes posted upstream:
https://lkml.org/lkml/2020/2/13/306

We will need backports to support Protected Virtualization.

IBM verified that the patches apply cleanly on focal/master-next, upstream commit ids for reference:

commit bab7e6f05699a481787f7659c4f766dd87187dae
Author: Halil Pasic <email address hidden>
Date: Thu Feb 13 13:37:27 2020 +0100

    virtio-blk: fix hw_queue stopped on arbitrary error

commit 24506976aec92052e9fe328146a2e574a1190986
Author: Halil Pasic <email address hidden>
Date: Thu Feb 13 13:37:28 2020 +0100

    virtio-blk: improve virtqueue error to BLK_STS

Also applies cleanly on 19.10.....

CVE References

bugproxy (bugproxy)
tags: added: architecture-all bugnameltc-184224 severity-critical targetmilestone-inin2004
Changed in ubuntu:
assignee: nobody → Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage)
affects: ubuntu → linux (Ubuntu)
Changed in ubuntu-power-systems:
assignee: nobody → Canonical Kernel Team (canonical-kernel-team)
importance: Undecided → Critical
Revision history for this message
Frank Heimes (fheimes) wrote :

Found the two commits in 'linux-next' ...

Frank Heimes (fheimes)
Changed in ubuntu-power-systems:
status: New → Triaged
Frank Heimes (fheimes)
description: updated
summary: - [UBUNTU 20.04] virtio-blk hw queue gets possibly permanently stopped
- when swiotlb full
+ [UBUNTU 20.04] virtio-blk disks can go dissfunctional when swiotlb fills
+ up
Revision history for this message
Frank Heimes (fheimes) wrote :

Patch request submitted:
https://lists.ubuntu.com/archives/kernel-team/2020-March/thread.html#108234
changing status to 'In Progress'.

Changed in ubuntu-power-systems:
assignee: Canonical Kernel Team (canonical-kernel-team) → Frank Heimes (fheimes)
Changed in linux (Ubuntu):
assignee: Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) → Frank Heimes (fheimes)
Changed in ubuntu-power-systems:
status: Triaged → In Progress
Changed in linux (Ubuntu):
status: New → In Progress
Frank Heimes (fheimes)
Changed in linux (Ubuntu):
status: In Progress → Fix Committed
Changed in ubuntu-power-systems:
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2020-03-25 10:35 EDT-------
Verificattion: looks good!

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 5.4.0-21.25

---------------
linux (5.4.0-21.25) focal; urgency=medium

  * CVE-2020-8835
    - SAUCE: bpf: undo incorrect __reg_bound_offset32 handling

 -- Thadeu Lima de Souza Cascardo <email address hidden> Thu, 26 Mar 2020 17:51:28 -0300

Changed in linux (Ubuntu):
status: Fix Committed → Fix Released
Frank Heimes (fheimes)
Changed in ubuntu-power-systems:
status: Fix Committed → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2020-03-31 07:44 EDT-------
IBM Buzgilla status-> closed, Fix Released with focal

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.