Cinder

Creating image-volume cache on NFS backend fails

Bug #1875570 reported by Pratik Shah on 2020-04-28

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	Undecided	Unassigned

Bug Description

Creating image-volume cache fails with NFS backend. Following are the steps to reproduce the issue.

1. Configure a host to enable image-volume cache using https://docs.openstack.org/cinder/latest/admin/blockstorage-image-volume-cache.html
2. Create a volume on a tenant

remotefs driver tries to create a temporary snapshot before creating a volume on internal tenant. This operation throws error. (See attached Cinder volume logs) This error is observed on Stein release.

Actual result:
- temporary snapshot gets stuck in `creating` state

Expected result:
- Image volume should have been created on internal tenant

Solution:
snapshot.id at https://github.com/openstack/cinder/blob/stable/stein/cinder/volume/drivers/remotefs.py#L1442
doesn't have `tmp-snap` in it as id is not passed as a option while creating snapshot object.
This should be change to `snapshot.display_name` at same location

Tags:

Revision history for this message

Pratik Shah (pratikshah) wrote on 2020-04-28:

cinder.log Edit (4.9 KiB, text/html)

Pratik Shah (pratikshah) on 2020-05-08

affects:

fuel-plugin-contrail → cinder

Eric Harney (eharney) on 2020-05-08

tags:

added: drivers nfs

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-05-08: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/726471

Changed in cinder:
assignee:	nobody → Sofia Enriquez (lsofia-enriquez)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-05-29: Fix merged to cinder (master)

Reviewed: https://review.opendev.org/726471
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e52ab1a3adbc8462b02c342ee7990e527a9f73bb
Submitter: Zuul
Branch: master

commit e52ab1a3adbc8462b02c342ee7990e527a9f73bb
Author: Sofia Enriquez <email address hidden>
Date: Fri May 8 20:24:48 2020 +0000

Creating image-volume cache on NFS backend fails

    snapshot.id doesn't have `tmp-snap` in it as id
    is not passed as a option while creating snapshot
    object. This should be change to
    `snapshot.display_name` at same location

Closes-Bug: #1875570
Change-Id: I66da0212a61d778fe9795d382b3af5b225a8aa54

Changed in cinder:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-05-30: Fix proposed to cinder (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/731934

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-06-01: Fix proposed to cinder (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/732400

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-06-01: Fix merged to cinder (stable/ussuri)

Reviewed: https://review.opendev.org/731934
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f68a64540f20967f933a3c9546837ddde23c20cd
Submitter: Zuul
Branch: stable/ussuri

commit f68a64540f20967f933a3c9546837ddde23c20cd
Author: Sofia Enriquez <email address hidden>
Date: Fri May 8 20:24:48 2020 +0000

Creating image-volume cache on NFS backend fails

    snapshot.id doesn't have `tmp-snap` in it as id
    is not passed as a option while creating snapshot
    object. This should be change to
    `snapshot.display_name` at same location

    Closes-Bug: #1875570
    Change-Id: I66da0212a61d778fe9795d382b3af5b225a8aa54
    (cherry picked from commit e52ab1a3adbc8462b02c342ee7990e527a9f73bb)

tags:

added: in-stable-ussuri

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-08-21: Fix merged to cinder (stable/train)

Reviewed: https://review.opendev.org/732400
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=193f3e97ce19bd8926bac23781e51d68de8ddcd4
Submitter: Zuul
Branch: stable/train

commit 193f3e97ce19bd8926bac23781e51d68de8ddcd4
Author: Sofia Enriquez <email address hidden>
Date: Fri May 8 20:24:48 2020 +0000

Creating image-volume cache on NFS backend fails

    snapshot.id doesn't have `tmp-snap` in it as id
    is not passed as a option while creating snapshot
    object. This should be change to
    `snapshot.display_name` at same location
    Also includes regression and NITs from other
    patches
    (I33da9c65ef56b3e4967170e3a0fb25f12e067876)
    (Ia620043904f4f31a81bc8463fb36476a149f9808)
    (Id0b4981be5bf4e79aedcdad2258fc64aad8eeb72)

    Closes-Bug: #1875570
    Change-Id: I66da0212a61d778fe9795d382b3af5b225a8aa54
    (cherry picked from commit f68a64540f20967f933a3c9546837ddde23c20cd)

tags:

added: in-stable-train

Sofia Enriquez (lsofia-enriquez) on 2020-08-21

Changed in cinder:
assignee:	Sofia Enriquez (lsofia-enriquez) → nobody

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-08-21: Fix proposed to cinder (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/747431

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-09-18: Fix merged to cinder (stable/stein)

Reviewed: https://review.opendev.org/747431
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=14f5a20dadb6590941633035a1dd8bcb0a7cb3b1
Submitter: Zuul
Branch: stable/stein

commit 14f5a20dadb6590941633035a1dd8bcb0a7cb3b1
Author: Sofia Enriquez <email address hidden>
Date: Fri May 8 20:24:48 2020 +0000

Creating image-volume cache on NFS backend fails

    Closes-Bug: #1875570
    Change-Id: I66da0212a61d778fe9795d382b3af5b225a8aa54
    (cherry picked from commit f68a64540f20967f933a3c9546837ddde23c20cd)
    (cherry picked from commit 193f3e97ce19bd8926bac23781e51d68de8ddcd4)