External links in Mahara no longer open in external tab/window by default
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Medium
|
Cecilia Vela Gurovic | ||
| 19.10 |
Fix Released
|
Medium
|
Unassigned | ||
| 20.04 |
Fix Released
|
Medium
|
Unassigned | ||
| 20.10 |
Fix Released
|
Medium
|
Cecilia Vela Gurovic | ||
Bug Description
Code: Release 2020.04_RC2
Browser/s: Chrome & Firefox
Theme: Raw
Summary: The functionality for related bug #1802205 'Make all external links in Mahara open in external tab/window by default' no longer works.
Steps:
As logged in PersonA:
1. Create a new page with a text block on it that has a few/5 paragraphs of text.
2. Use the tinymce editor to add the following links before the text paragraphs using the Insert/Edit Link modal:
a. External URL = https:/
Text to display = 'Catalyst default-None, new tab/window'
Open link in... = 'None'
b. External URL = https:/
Text to display = 'Catalyst -same page'
Open link in... = 'Same page'
c. External URL display = https:/
Text to display = 'Catalyst -new tab/window'
Open link in... = 'New window'
d. Internal URL = http://
Text to display = 'Profile page default-None, same tab/window'
Open link in... = 'None'
e. Internal URL = http://
Text to display = 'Profile page - same page',
Open link in... = 'Same page'
f. Internal URL = http://
Text to display = 'Profile page - new tab/window'
Open link in... = 'New window'.
3. At the bottom of the page, enter the text 'End of page' select the text and use the tinymce editor to create an anchor tag (3rd option line, second to last icon) named 'Page_End'.
4. Create the following in block link to the 'Page_End' anchor from the top of the page:
URL = #Page_End
Text to display = 'Link to page end -default None'
Open link in... = 'None'
Expected results: When selected, each link should behave as per its displayed link text.
Actual results: all links behave as expected EXCEPT for 2.a.
| Cecilia Vela Gurovic (ceciliavg) wrote | #1 |
| Changed in mahara: | |
| assignee: | nobody → Cecilia Vela Gurovic (ceciliavg) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| Changed in mahara: | |
| milestone: | none → 20.10.0 |
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #2 |
| tags: | added: regression |
| Mahara Bot (dev-mahara) wrote A change has been merged | #3 |
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #4 |
| Mahara Bot (dev-mahara) wrote A change has been merged | #5 |
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #6 |
| Mahara Bot (dev-mahara) wrote A change has been merged | #7 |
| Changed in mahara: | |
| milestone: | 20.10.0 → none |
This stopped working on blocks in a page with gridstack.
It looks like the script to replace the target in links is triggered when the page is ready, but the blocks have not loaded yet