Ubuntu
plasma-nm package

[SRU focal] Bad theming/colors network manager (connections)

Bug #1879033 reported by Rik Mills on 2020-05-16

This bug affects 1 person

	Status	Importance	Assigned to
plasma-nm (Ubuntu)	Fix Released	High	Rik Mills
Focal	Fix Released	High	Rik Mills
Groovy	Fix Released	High	Rik Mills

Bug Description

Release focal and Groovy:
Version: 5.18.4 and 5.18.5

Discussed with SRU team member here: https://irclogs.ubuntu.com/2020/05/13/%23ubuntu-release.html#t08:19

[Impact]

As per the upstream bug, the functional button row in the connections manager list inherits the background colour from the current Plasma theme instead of the intended base colour for the chosen application widgets colour scheme.

This results in Kubuntu (and any circumstance where a light app widget and dark plasma theme being chosen) in the button background and icons on them being the same or nearly undistinguishable dark colour.

For a person with good eyesight this makes it hard to distinguish the action icon on the buttons, but for someone with vision issues this is a critical visual interface bug.

[Test Case]

* Right click network icon in system tray, and select configure network connections. Or open systemsettings and navigate to Network > Connections

* The bug will be evident in the connection list.

* Test with a variety of dark or coloured Plasma themes form the system and store.kde.org

[Regression Potential]

* Low as this impacts and the fix applies to a single KCM, and does not more widely impact the general KCM implementation.

* This us tested well upstream for Breeze, and in Groovy for other theme combinations, but it could cause some 3rd party themes that use unusual schemes to not display well in the KCM. However, as this SRU is restoring the intended correct behaviour, such corner cases should fix their issues there.

Upstream Bug:

https://bugs.kde.org/show_bug.cgi?id=418416

This is fix upstream with:

https://cgit.kde.org/plasma-nm.git/commit/?id=c9b2684a49d369dcfef95e0c26a64664138fc434

and

https://cgit.kde.org/plasma-nm.git/commit/?id=7de9e9cdbd57b991226fe7467fbca4841e73e9e0

This will require the kirigami qml module to be added as a new runtime depend, but this has been agreed as acceptable with the SRU team.

See original description

Tags:

Revision history for this message

Rik Mills (rikmills) wrote on 2020-05-16:

Bad theming Edit (71.6 KiB, image/png)

Changed in plasma-nm (Ubuntu):
status:	New → Confirmed
importance:	Undecided → High
Changed in plasma-nm (Ubuntu Focal):
status:	New → Confirmed
importance:	Undecided → High

Revision history for this message

Launchpad Janitor (janitor) wrote on 2020-05-16:

This bug was fixed in the package plasma-nm - 4:5.18.5-0ubuntu2

---------------
plasma-nm (4:5.18.5-0ubuntu2) groovy; urgency=medium

  * Backport patch from upstream Plasma 5.19 to fix connection list
    buttons theming. (LP: #1879033)
    - debian/patches: upstream_use-system-kirigami-color-scheme.patch
    - debian/control: Add qml-module-org-kde-kirigami2 runtime
      dependency.

-- Rik Mills <email address hidden> Sat, 16 May 2020 10:05:40 +0100

Changed in plasma-nm (Ubuntu Groovy):
status:	Confirmed → Fix Released

Rik Mills (rikmills) on 2020-05-23

description:	updated
summary:	- Bad theming/colors network manager (connections) + [SRU focal] Bad theming/colors network manager (connections)
Changed in plasma-nm (Ubuntu Focal):
assignee:	nobody → Rik Mills (rikmills)
Changed in plasma-nm (Ubuntu Groovy):
assignee:	nobody → Rik Mills (rikmills)

Rik Mills (rikmills) on 2020-05-23

Changed in plasma-nm (Ubuntu Focal):
status:	Confirmed → In Progress

Revision history for this message

Brian Murray (brian-murray) wrote on 2020-05-26:

Could you provide a reference to the conversation / sign off you received from an SRU team member?

Changed in plasma-nm (Ubuntu Focal):
status:	In Progress → Incomplete

Revision history for this message

Rik Mills (rikmills) wrote on 2020-05-26:

IRC logs of discussion: https://irclogs.ubuntu.com/2020/05/13/%23ubuntu-release.html#t08:19

description:

updated

Rik Mills (rikmills) on 2020-05-27

Changed in plasma-nm (Ubuntu Focal):
status:	Incomplete → In Progress

Revision history for this message

Brian Murray (brian-murray) wrote on 2020-05-27: Please test proposed package

Hello Rik, or anyone else affected,

Accepted plasma-nm into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/plasma-nm/4:5.18.4.1-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in plasma-nm (Ubuntu Focal):
status:	In Progress → Fix Committed
tags:	added: verification-needed verification-needed-focal

Revision history for this message

Paul White (paulw2u) wrote on 2020-06-02:

I followed the text case and confirmed that what I saw matched the screenshot in comment #1, i.e. four icons displayed against a dark background so almost unreadable.

I enabled -proposed and installed plasma-nm 4:5.18.4.1-0ubuntu1.1 and went through the test case again. The four icons are now shown against a light background and perfectly readable.

So consider fix verified.

tags:	added: verification-done-focal removed: verification-needed-focal
tags:	added: verification-done removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2020-06-04:

This bug was fixed in the package plasma-nm - 4:5.18.4.1-0ubuntu1.1

---------------
plasma-nm (4:5.18.4.1-0ubuntu1.1) focal; urgency=medium

-- Rik Mills <email address hidden> Sat, 23 May 2020 13:52:17 +0100

Changed in plasma-nm (Ubuntu Focal):
status:	Fix Committed → Fix Released

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2020-06-04: Update Released

The verification of the Stable Release Update for plasma-nm has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.