Evergreen

Monograph parts page does not display with fix for JQuery upgrade

Bug #1880035 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
Evergreen 3.5.0
3.3
Fix Released
High
Unassigned
Evergreen 3.3.7
3.4
Fix Released
High
Unassigned
Evergreen 3.4.3

Bug Description

The fix for bug 1873286 has brought to light an issue with our use of dojo, at least in the monograph parts template. The simple change from <table ...... /> to <table ... ></table> in Open-ILS/src/templates/conify/global/biblio/monograph_part.tt2 causes the entire page to fail to render.

See original description
Jason Boyer (jboyer)
description: updated
Revision history for this message
Jason Boyer (jboyer) wrote :

The fix is simple and the branch is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1880035_render_parts / working/user/jboyer/lp1880035_render_parts

Thanks to Galen for tracking down the cause and finding a solution.

tags: added: pullrequest
Changed in evergreen:
importance: Undecided → High
milestone: none → 3.5.0
no longer affects: evergreen/3.5
Revision history for this message
Jason Stephenson (jstephenson) wrote :

We've confirmed this bug at CW MARS, and we're testing the patch branch.

Changed in evergreen:
status: New → Confirmed
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

It works for us on 3.2.10 with the jQuery branch backported. I've pushed a signoff branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1880035_render_parts_signoff

I figure more thorough testing could be in order, particularly on 3.5 and/or 3.4.

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
tags: added: signedoff
Revision history for this message
Jason Stephenson (jstephenson) wrote :

CW MARS has this patch in production on 3.2.10 since Tuesday, 5/26.

Revision history for this message
Bill Erickson (berick) wrote :

Issue and fix confirmed. Thanks, All. Merged to 3.3 and up.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
Jason Stephenson (jstephenson)
Changed in evergreen:
milestone: 3.5.0 → 3.6-beta
milestone: 3.6-beta → 3.5.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.