ctrl+space freezes irssi on focal

Bug #1882401 reported by Daniel S. Sterling
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
irssi (Ubuntu)
Fix Released
High
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

[SRU Justification]
pressing Ctrl+Space in an irssi window (whether intentionally or by accident) causes the application to freeze and it is not possible to un-freeze it.

[Test case]
1. Run irssi
2. Type
3. Press Ctrl+Space
4. Try to type some more, observe that it doesn't work
5. Kill irssi
6. Upgrade to the package from -proposed
7. Run irssi
8. Type
9. Press Ctrl+Space
10. Type some more, observe that the characters appear.

[Regression potential]
This is a targeted patch that specifically detects the case that NUL is received in input as returned by new glib. I don't see any way that this could cause regressions.

[Original description]

see https://github.com/irssi/irssi/issues/1180

there is a patch available for this that needs to be applied to irssi for focal

from GitHub issue:

"A change in GLib 2.63 broke some assumptions in Irssi that the null-byte NUL / U+0000 is a valid Unicode character. This would occur when the user types Ctrl+Space. As a result, the input loop never manages to process the NUL-byte (and any other user input that follows, ever).

This affects all versions of Irssi as soon as your system is updated to this GLib version."

Revision history for this message
Balint Harmath (bharmath) wrote :

The solution is provided - apply patch.

Changed in irssi (Ubuntu):
status: New → Confirmed
tags: added: focal groovy
Changed in irssi (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → High
milestone: none → focal-updates
Revision history for this message
Sebastien Bacher (seb128) wrote :

The fix to backport is https://patch-diff.githubusercontent.com/raw/irssi/irssi/pull/1183.patch

Tagging for the foundation team to review, sounds like a worth SRU candidate for focal

Changed in irssi (Ubuntu):
status: Triaged → Fix Committed
status: Fix Committed → Triaged
tags: added: rls-ff-incoming
Steve Langasek (vorlon)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package irssi - 1.2.2-1ubuntu2

---------------
irssi (1.2.2-1ubuntu2) groovy; urgency=medium

  * debian/patches/1183.patch: [PATCH] manually handle NUL unicode in
    g_utf8_get_next_char_validated. Thanks to ailin-nemui <ailin-
    <email address hidden>>. Closes LP: #1882401.

 -- Steve Langasek <email address hidden> Thu, 06 Aug 2020 15:56:50 -0700

Changed in irssi (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Daniel, or anyone else affected,

Accepted irssi into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/irssi/1.2.2-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in irssi (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Paul White (paulw2u) wrote :

I didn't have irssi installed so I installed version 1.2.2-1ubuntu1 to confirm that the issue exists. Without connecting to an IRC server I typed random characters into the input buffer and after typing Ctrl-Space was unable to type any further characters.

After upgrading irssi to version 1.2.2-1ubuntu1.1 I was able to type further characters after typing Ctrl-Space. So changing tags to mark this issue as fixed and verify this SRU.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
tags: removed: rls-ff-incoming
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Oh my, and I was wondering why my irssi froze and was unresponsive a bit back. Guess it was this bug!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package irssi - 1.2.2-1ubuntu1.1

---------------
irssi (1.2.2-1ubuntu1.1) focal; urgency=medium

  * debian/patches/1183.patch: manually handle NUL unicode in
    g_utf8_get_next_char_validated. Thanks to ailin-nemui <ailin-
    <email address hidden>>. Closes LP: #1882401.

 -- Steve Langasek <email address hidden> Thu, 06 Aug 2020 15:56:50 -0700

Changed in irssi (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for irssi has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.