Lollypop music player mixes Yaru and Adwaita symbols

Bug #1887419 reported by Stuart Jaggers
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Yaru Theme
Fix Released
Unknown
yaru-theme (Ubuntu)
Fix Released
Low
Unassigned
Focal
Fix Released
Low
Unassigned

Bug Description

[Impact]

 * The Yaru theme has some of the icons used by Lollypop but not all of them. This results in the Lollypop sidebar having a mix of Adwaita symbols (with 2px strokes) and Yaru ones (which have 1px). See GitHub issue https://github.com/ubuntu/yaru/issues/2208.

 * Reason to backport to Focal: displaying symbols from two different themes gives a poor impression of Ubuntu to users who want to use a popular native music player.

[Test Case]

 * Install Lollypop and look at the sidebar. Some of the symbols are heavy and some are light. (Alternatively, the GitHub issue linked above has a screenshot.)

 * Install yaru from -proposed and notice how the Lollypop sidebar is now consistent with itself and the rest of the Yaru theme.

[Regression Potential]

 * No regression potential.

 * Tested by building Yaru from source.

[Other Info]

 * Links to the GitHub PRs: https://github.com/ubuntu/yaru/pull/2235 and https://github.com/ubuntu/yaru/pull/2253.

Changed in yaru-theme (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Changed in yaru:
status: Unknown → Fix Released
Changed in yaru-theme (Ubuntu Focal):
importance: Undecided → Low
status: New → Triaged
Changed in yaru-theme (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yaru-theme - 20.10.2

---------------
yaru-theme (20.10.2) groovy; urgency=medium

  [ Carlo Lobrano ]
  * update README pictures (LP: #1887383)
  * build: deduplicate meson.build and introduce Flavours (#1884) (LP: #1887383)
  * fix Yaru project name (LP: #1887383)
  * Fix spinner typo in tweaks.scss (LP: #1887383)
  * bootstrap: libgtk-3-dev is needed for building too (#2222) (LP: #1887383)

  [ Feichtmeier ]
  * Gtk theme new changes from upstream (#2195)
  * Special case spinners in destructive, suggested action buttons (#2187)
    (LP: #1887298)
  * Make wacom overlay visible (#2198) (LP: #1887300)
  * Shell: revert insensitive fg color change (#2199)
  * Gtk3: increase menu visibility (#2232) (LP: #1887297)
  * Shell: popup and notification improvements (#2236) (LP: #1887297)

  [ github-actions[bot] ]
  * New upstream snapshot for GTK (#2084)

  [ Ԝеѕ ]
  * icons - add application/x-sharedlib alias for x-executable (#2204)
  * Use CD image icon for apple disk images (#2233)

  [ Chris Billington ]
  * Use MESON_INSTALL_DESTDIR_PREFIX in post_install.py (#2206) (LP: #1887383)

  [ ubuntujaggers ]
  * adding second user to system-users (#2209) (LP: #1887411)
  * Adding mimetype for LMMS projects (#2249) (LP: #1887388)
  * Some missing icons for Lollypop UI (#2235) (LP: #1887419)
  * Adding new non-uniform app icon templates (#1920)
  * removing green from network-cellular-connected-symbolic (#2252) (LP:
    #1887420)
  * rounding corners on avatar-default-symbolic (#2253)

  [ R. David Dunphy ]
  * Nemo selected text highlighting and inactive pane shading (#2220)

  [ John Losito ]
  * Check for updates to GitHub Actions every weekday (#2223) (LP: #1887383)

  [ Jupiter007 ]
  * Add a solid background to microphone icons (#2200) (Closes: #2185)
    (LP: #1887389)
  * Re: Fix lock icons twisted path (#2205) (Closes: #2201) (LP: #1887393)
  * Add missing Simple-scan symbolic icons (#2244)

  [ MadsRH ]
  * Added text to img and iso icons (#2213)
  * Added mimetype for Lilypond music files (#2230) (LP: #1887388)
  * Added icon for QML mimetypes (#2226) (LP: #1887388)
  * Added mimetype icon for log files (#2229) (LP: #1887388)
  * Added more mimetype icons again (#2234) (LP: #1887388)
  * Added mimetype icon for Scala files (#2231) (LP: #1887388)

  [ Muqtadir ]
  * mimetype application-x-theme (#2243) (LP: #1887388)
  * Mimetypes application x rss+xml (#2248) (LP: #1887388)

  [ Marco Trevisan (Treviño) ]
  * debian/rules: enable building unity theme

 -- Marco Trevisan (Treviño) <email address hidden> Fri, 17 Jul 2020 02:43:50 +0200

Changed in yaru-theme (Ubuntu):
status: In Progress → Fix Released
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Stuart, or anyone else affected,

Accepted yaru-theme into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/yaru-theme/20.04.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in yaru-theme (Ubuntu Focal):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Stuart Jaggers (jaggers) wrote :

Thank you! I've updated to focal-proposed and can confirm that this bug is fixed.

Revision history for this message
Stuart Jaggers (jaggers) wrote :

(Tested by running Lollypop ver 1.2.35 and checking all the affected symbols.)

tags: added: verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Luna Jernberg (bittinubuntu) wrote :

Was in this weeks Ubuntu Desktop meeting as i was fiddling around in my IRC client so did a spontaneous test today looks like this: http://imgur.com/a/jgdEPIs

But feeling sick this week, so gonna go rest now

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yaru-theme - 20.04.8

---------------
yaru-theme (20.04.8) focal; urgency=medium

  [ Carlo Lobrano, Chris Billington, John Losito, ubuntujaggers ]
  * updates not related to themes and icons (LP: #1887383)

  [ Feichtmeier ]
  * Fix visibility of spinner on destructbutton (LP: #1887298)
  * Make wacom overlay visible (LP: #1887300)
  * Increase Gtk3 menu and Shell popup visibility (LP: #1887297)

  [ MadsRH, Muqtadir, Wes, ubuntujaggers ]
  * Update supported mimetype icons (LP: #1887388)

  [ ubuntujaggers ]
  * Fix system-users-symbolic to represent multiple users (LP: #1887411)
  * Add missing icons for Lollypop UI (LP: #1887419)
  * Removing green from network-cellular-connected-symbolic (LP: #1887420)
  * Rounding corners on avatar-default-symbolic (#2253)

  [ R. David Dunphy ]
  * Nemo selected text highlighting and inactive pane shading (#2220)

  [ Jupiter007 ]
  * Add a solid background to microphone icons (LP: #1887389)
  * Fix system-lock-screen twisted path (LP: #1887393)
  * Add missing Simple-scan symbolic icons (#2244)

  [ Marco Trevisan (Treviño) ]
  * debian/rules: enable building unity theme (related to lp:1887383)

 -- Marco Trevisan (Treviño) <email address hidden> Fri, 17 Jul 2020 03:15:44 +0200

Changed in yaru-theme (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for yaru-theme has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.