Last 4 digits of phone number for password doesn't work with pending users

This also affects 3.3. We just activated self-registration, and our workaround in the few weeks we've been using it has been to ask staff users to make sure to click in the daytime phone field.

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1887852_pending_patron_stage_pwd

PaILS/SPARK 3.3.4 Just realized this also affects the Zip Code field when it is used to fill in State and County. New branch or can we roll it in? What other fields might be affected by this?

Okay, looks like it should be another wishlist item for the zip code field. Thanks

Testing this patch on Firefox 81 and it's not working for me. I'm not going to mark this as needs repatch yet as it might be good for someone else to test. Firefox is pretty aggressive about caching so I"ve had issues with testing something like a regctl.js only patch but the usual tricks aren't making a difference here.

For reference, these are the steps I needed to go through to test:

1 - enable patron self-registration
2 - show day_phone on patron registration
3 - set "Patron: password from phone #" for the relevant orgs
4 - register a patron and provide a daytime phone number
5 - In the admin interface, visit the pending patron pages and open the patron that I self-registered
6 - Note that the password field is not populated with the last 4 digits of the daytime phone number

Part of what makes the testing tricky is that there are 3 phone number fields, and it wasn't clear which one is relevant. Apparently daytime phone number is the one used.

I did 3 tests which were successful. I consent to sign off on this with my name, Mike Risher, and my email <email address hidden>

Notes:

* I tested using Chrome.
* step #6 above should say "...password field _is_ populated..."

The patch does not work for me with either Chrome or Firefox. I've tried with regular and incognito/private windows and cleared the cache for my test site multiple times.

I've added the needsrepatch tag.

OK! I'm taking this bug again because I made a mistake and copied the file to the wrong place and it didn't realize that until after. (I should have just done the whole install dance.)

It looks like Mike caught a mistake in my testing steps - I forgot to include that you need to set the [Patron: password from phone #] org unit setting as well. It would help if I remembered to include that given that's the feature that's being fixed! My mistake.

It's all right, Dan. After I put regctl.js in the correct location, dealt with cache and Lovefield issues, the patch is working for me as it should.

I have pushed the fix to master, rel_3_6, and rel_3_5.

Thanks, Dan, Mike, and everyone else!