Mahara

clean up references to old menu structure

  1. Series 19.04
  2. Bug #1888743
Bug #1888743 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.04
Fix Released
Low
Unassigned
Mahara 19.04.7
19.10
Fix Released
Low
Unassigned
Mahara 19.10.5
20.04
Fix Released
Low
Unassigned
Mahara 20.04.2
20.10
Fix Released
Low
Lisa Seeto
Mahara 20.10.0

Bug Description

Currently we still have some references to the old menu structure within Mahara.
'myportfolio' and 'content' should both be updated to 'create'.

Change: define(MENUITEM', 'myportfolio');
To: define('MENUITEM', 'create');

In the following files:
relatedtags.php
artefact/annotation/edit.php
artefact/comment/edit.php
artefact/peerassessment/edit.php

In artefact/internal/socialprofile.php:
Change: define('MENUITEM', 'content/profile');
To: define('MENUITEM', 'create/files');

In htdocs/lib/web.php:
Change (ln 1476 in a comment): in_array(MENUITEM, array('myportfolio/view'))),
To: in_array(MENUITEM, array('create/view'))),

The old code was discovered when upgrading a site from 18.10 to 20.04.

Tags: refactoring
Lisa Seeto (lisaseeto)
tags: added: refactoring
removed: code-cleanup
Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Lisa Seeto (lisaseeto)
Lisa Seeto (lisaseeto)
Changed in mahara:
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11094

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
importance: Undecided → Low
milestone: none → 20.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11094
Committed: https://git.mahara.org/mahara/mahara/commit/fa72b91e0cc75a5824db75569ce3ec2a0f3d897b
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit fa72b91e0cc75a5824db75569ce3ec2a0f3d897b
Author: Lisa Seeto <email address hidden>
Date: Thu Jul 30 12:40:46 2020 +1200

Bug 1888743: clean up references to old menu structure

- updated old references using set_nav func when appropriate
- delete peerassessment/edit.php as it's no longer used

Change-Id: Iabba2d703a89cce5655d4d6220caf352bf53ab1e
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11124

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11125

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11126

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11124
Committed: https://git.mahara.org/mahara/mahara/commit/e49a4cdc22ed70d23fab1b369006c868745fe972
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 20.04_STABLE

commit e49a4cdc22ed70d23fab1b369006c868745fe972
Author: Lisa Seeto <email address hidden>
Date: Thu Jul 30 12:40:46 2020 +1200

Bug 1888743: clean up references to old menu structure

- updated old references using set_nav func when appropriate
- delete peerassessment/edit.php as it's no longer used

Change-Id: Iabba2d703a89cce5655d4d6220caf352bf53ab1e
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit fa72b91e0cc75a5824db75569ce3ec2a0f3d897b)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11125
Committed: https://git.mahara.org/mahara/mahara/commit/474c6486300897d99c3a1036d0f4a0b32ec29d8c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 474c6486300897d99c3a1036d0f4a0b32ec29d8c
Author: Lisa Seeto <email address hidden>
Date: Thu Jul 30 12:40:46 2020 +1200

Bug 1888743: clean up references to old menu structure

- updated old references using set_nav func when appropriate
- delete peerassessment/edit.php as it's no longer used

Change-Id: Iabba2d703a89cce5655d4d6220caf352bf53ab1e
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit fa72b91e0cc75a5824db75569ce3ec2a0f3d897b)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11126
Committed: https://git.mahara.org/mahara/mahara/commit/c640247ee35318eb9516ae6d8c15511bee3f3be0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit c640247ee35318eb9516ae6d8c15511bee3f3be0
Author: Lisa Seeto <email address hidden>
Date: Thu Jul 30 12:40:46 2020 +1200

Bug 1888743: clean up references to old menu structure

- updated old references using set_nav func when appropriate
- delete peerassessment/edit.php as it's no longer used

Change-Id: Iabba2d703a89cce5655d4d6220caf352bf53ab1e
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit fa72b91e0cc75a5824db75569ce3ec2a0f3d897b)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.