ASoC:amd:renoir: the dmic can't record sound after suspend and resume

Bug #1890220 reported by Hui Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
Critical
Hui Wang
Focal
Fix Released
Critical
Unassigned
linux-oem-5.6 (Ubuntu)
Fix Released
Critical
Unassigned
Focal
Fix Released
Critical
Unassigned

Bug Description

[Impact]
We have backported the amd renoir audio driver to oem-5.6 and focal
kernel, recently we found if the dmic is working and we suspend and
resume, the dmic can't record the sound after resume.

[Fix]
After resuming, the driver needs to restore 2 more registers, then the
dmic could record the sound.

[Test Case]
Boot the kernel with this patch, open the sound-setting and run suspend
and resume, then use arecord to record the sound, verify the sound is
successfully recorded by aplaying it.

[Regression Risk]
Low, this patch is verified on the amd renoir machine, and this patch
got ack from AMD engineer.

CVE References

Hui Wang (hui.wang)
Changed in linux (Ubuntu):
importance: Undecided → Critical
Changed in linux (Ubuntu Focal):
importance: Undecided → Critical
Changed in linux-oem-5.6 (Ubuntu):
importance: Undecided → Critical
Changed in linux-oem-5.6 (Ubuntu Focal):
importance: Undecided → Critical
Changed in linux (Ubuntu):
status: New → Triaged
Changed in linux (Ubuntu Focal):
status: New → Triaged
Changed in linux (Ubuntu):
status: Triaged → Fix Released
Changed in linux-oem-5.6 (Ubuntu):
status: New → Triaged
Changed in linux-oem-5.6 (Ubuntu Focal):
status: New → Triaged
Hui Wang (hui.wang)
description: updated
Changed in linux (Ubuntu Focal):
status: Triaged → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Hui Wang (hui.wang) wrote :

Boot with the -proposed kernel on the lenovo amd renoir machine, open the gnome-sound-setting, let the dmic work, then suspend and resume, check the dmic, it still works.

Verified done with the focal kernel.

tags: added: verification-done-focal
removed: verification-needed-focal
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.6 (Ubuntu Focal):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.6 - 5.6.0-1023.23

---------------
linux-oem-5.6 (5.6.0-1023.23) focal; urgency=medium

  * focal/linux-oem-5.6: 5.6.0-1023.23 -proposed tracker (LP: #1892465)

  * CVE-2020-15852
    - x86/ioperm: Fix io bitmap invalidation on Xen PV

  * Fix non-working USB devices plugged during system sleep (LP: #1892678)
    - xhci: Do warm-reset when both CAS and XDEV_RESUME are set

  * ASPM not enabled on child devices behind VMD controller (LP: #1889384)
    - SAUCE: PCI/ASPM: Enable ASPM for links under VMD domain

  * Fix non-working Goodix touchpad after system sleep (LP: #1891998)
    - HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands

  * [SRU] Fix acpi backlight issue on some thinkpads (LP: #1892010)
    - platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts

 -- Timo Aaltonen <email address hidden> Tue, 25 Aug 2020 08:46:08 +0300

Changed in linux-oem-5.6 (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (97.9 KiB)

This bug was fixed in the package linux - 5.4.0-45.49

---------------
linux (5.4.0-45.49) focal; urgency=medium

  * focal/linux: 5.4.0-45.49 -proposed tracker (LP: #1893050)

  * [Potential Regression] dscr_inherit_exec_test from powerpc in
    ubuntu_kernel_selftests failed on B/E/F (LP: #1888332)
    - powerpc/64s: Don't init FSCR_DSCR in __init_FSCR()

linux (5.4.0-44.48) focal; urgency=medium

  * focal/linux: 5.4.0-44.48 -proposed tracker (LP: #1891049)

  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts

  * ipsec: policy priority management is broken (LP: #1890796)
    - xfrm: policy: match with both mark and mask on user interfaces

linux (5.4.0-43.47) focal; urgency=medium

  * focal/linux: 5.4.0-43.47 -proposed tracker (LP: #1890746)

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  * Devlink - add RoCE disable kernel support (LP: #1877270)
    - devlink: Add new "enable_roce" generic device param
    - net/mlx5: Document flow_steering_mode devlink param
    - net/mlx5: Handle "enable_roce" devlink param
    - IB/mlx5: Rename profile and init methods
    - IB/mlx5: Load profile according to RoCE enablement state
    - net/mlx5: Remove unneeded variable in mlx5_unload_one
    - net/mlx5: Add devlink reload
    - IB/mlx5: Do reverse sequence during device removal

  * msg_zerocopy.sh in net from ubuntu_kernel_selftests failed (LP: #1812620)
    - selftests/net: relax cpu affinity requirement in msg_zerocopy test

  * Enlarge hisi_sec2 capability (LP: #1890222)
    - Revert "UBUNTU: [Config] Disable hisi_sec2 temporarily"
    - crypto: hisilicon - update SEC driver module parameter

  * Fix missing HDMI/DP Audio on an HP Desktop (LP: #1890441)
    - ALSA: hda/hdmi: Add quirk to force connectivity

  * Fix IOMMU error on AMD Radeon Pro W5700 (LP: #1890306)
    - PCI: Mark AMD Navi10 GPU rev 0x00 ATS as broken

  * ASoC:amd:renoir: the dmic can't record sound after suspend and resume
    (LP: #1890220)
    - SAUCE: ASoC: amd: renoir: restore two more registers during resume

  * No sound, Dummy output on Acer Swift 3 SF314-57G with Ice Lake core-i7 CPU
    (LP: #1877757)
    - ASoC: SOF: Intel: hda: fix generic hda codec support

  * Fix right speaker of HP laptop (LP: #1889375)
    - SAUCE: hda/realtek: Fix right speaker of HP laptop

  * blk_update_request error when mount nvme partition (LP: #1872383)
    - SAUCE: nvme-pci: prevent SK hynix PC400 from using Write Zeroes command

  * soc/amd/renoir: detect dmic from acpi table (LP: #1887734)
    - ASoC: amd: add logic to check dmic hardware runtime
    - ASoC: amd: add ACPI dependency check
    - ASoC: amd: fixed kernel warnings

  * soc/amd/renoir: change the module name to make it work with ucm3
    (LP: #1888166)
    - AsoC: amd: add missing snd- module prefix to the acp3x-rn driver kernel
      module
    - SAUCE: remove a kernel module since its name is changed

  * Focal update: v5.4.55 upstream stable release (LP: #1890343)
    - AX.25: Fix out-of-bounds read in ax25_connect()
    - AX.25: Prevent out-of-bounds read in ax25_sendmsg()
    - dev: Defer free of skbs in flush_backlog
    - drivers/net/wan/x25_asy: Fix to make i...

Changed in linux (Ubuntu Focal):
status: Fix Committed → Fix Released
Hui Wang (hui.wang)
Changed in linux-oem-5.6 (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.