Stop loading login form everytime a page is loaded

Bug #1892437 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic

Bug Description

This library is loaded as part of the login form, but we actually don't need it while the already logged in.

Loading it every time consumes extra resources that can be avoided.

See attached images from the js profiling result, this file takes more time to load than the rest of the libraries.

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11164

Lisa Seeto (lisaseeto)
Changed in mahara:
status: New → In Progress
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote : Re: stop loading zxcvbn.js library everytime a page is loaded

Why is it loading on the login form anyway? Shouldn't it only be loaded where we determine the password strength, i.e. on sign-up or when changing the password?

Changed in mahara:
importance: Undecided → High
milestone: none → 20.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11164
Committed: https://git.mahara.org/mahara/mahara/commit/6c894a7ab65e46905056bd7d4712964a65194afd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6c894a7ab65e46905056bd7d4712964a65194afd
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Aug 21 13:06:36 2020 +1200

Bug 1892437: login form, dont create it if not needed

behatnotneeded

Change-Id: Ibc856cbbcbc1790f73478343aa5c5ef5af31bf8a

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
summary: - stop loading zxcvbn.js library everytime a page is loaded
+ stop loading login form everytime a page is loaded
summary: - stop loading login form everytime a page is loaded
+ Stop loading login form everytime a page is loaded
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.