Mahara

Admin reports that list pages should only have links if admin can view page

Bug #1893607 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Lisa Seeto
Mahara 20.10.0

Bug Description

In some of the admin reports there are pages / collections listed as links to the referenced page.

But admins might not have access to the page (without masquerading) so we should only show the links for the pages they have access to (or force them to masquerade maybe)

Tags: manualupdate
Lisa Seeto (lisaseeto)
Changed in mahara:
status: New → In Progress
assignee: nobody → Lisa Seeto (lisaseeto)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11200

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Cases in which people with access to reports should be able to see portfolios:

- Shared with them (personally, member of a group, friends)
- Shared with registered account holders
- Shared with public
- Shared with institution

That goes for anyone with access to a report, which is typically institution and site administrators but can also be staff members for the portfolio access report.

Changed in mahara:
importance: Undecided → Medium
milestone: none → 20.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11200
Committed: https://git.mahara.org/mahara/mahara/commit/f2196d735e9988a951d546eefb918edcf1f42e6e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f2196d735e9988a951d546eefb918edcf1f42e6e
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 1 12:20:18 2020 +1200

Bug 1893607: Admin reports that list pages should only have links if admin can view page

- add check to see if USER can view portfolio to conditionally display URL
- add check for item pending to conditionally display pending text
- alter formatting of template for readability
- remove pending styling for entire column (needed to have $item->pending != null to work
so wasn't working already, and if displayed, requires further styling to have accesible contrast

Change-Id: Ice988ab891c8369e2bc4b323b3a0316f7989aae5
Signed-off-by: Lisa Seeto <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
tags: added: manualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.