Mahara

Changing some SAML functions calls to be namespaced

Bug #1895476 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
19.10
Fix Released
High
Unassigned
Mahara 19.10.5
20.04
Fix Released
High
Unassigned
Mahara 20.04.2
20.10
Fix Released
High
Unassigned
Mahara 20.10.0

Bug Description

Fixing up places where the following error occurs

error: call the class or interface 'SimpleSAML_*' correctly

As SAML now is using namespaces, so should the local calls to the methods, so

 'SimpleSAML_Configuration' becomes 'SimpleSAML\Configuration'
 'SimpleSAML_Metadata_MetaDataStorageSource' becomes 'SimpleSAML\Metadata\MetaDataStorageSource'

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11227
Committed: https://git.mahara.org/mahara/mahara/commit/997550f96572ce2d1bb89f910143785a8bbf657f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 997550f96572ce2d1bb89f910143785a8bbf657f
Author: Robert Lyon <email address hidden>
Date: Mon Sep 7 14:53:08 2020 +1200

Bug 1895476: call the class or interface 'SimpleSAML_*' correctly

It is now using namespaces, so
'SimpleSAML_Configuration' becomes 'SimpleSAML\Configuration'
'SimpleSAML_Metadata_MetaDataStorageSource' becomes
'SimpleSAML\Metadata\MetaDataStorageSource'

Change-Id: Icfe4fac03e8857688b1128ef0884ebde8c0d40a6
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11276

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11277

Robert Lyon (robertl-9)
no longer affects: mahara/19.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11276
Committed: https://git.mahara.org/mahara/mahara/commit/089175b67443b9ced20d1374958d90f917a97e11
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 089175b67443b9ced20d1374958d90f917a97e11
Author: Robert Lyon <email address hidden>
Date: Mon Sep 7 14:53:08 2020 +1200

Bug 1895476: call the class or interface 'SimpleSAML_*' correctly

It is now using namespaces, so
'SimpleSAML_Configuration' becomes 'SimpleSAML\Configuration'
'SimpleSAML_Metadata_MetaDataStorageSource' becomes
'SimpleSAML\Metadata\MetaDataStorageSource'

Change-Id: Icfe4fac03e8857688b1128ef0884ebde8c0d40a6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 997550f96572ce2d1bb89f910143785a8bbf657f)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11277
Committed: https://git.mahara.org/mahara/mahara/commit/6f60ed20e5d8e9db00f490f3ed61d2387e1836d3
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 6f60ed20e5d8e9db00f490f3ed61d2387e1836d3
Author: Robert Lyon <email address hidden>
Date: Mon Sep 7 14:53:08 2020 +1200

Bug 1895476: call the class or interface 'SimpleSAML_*' correctly

It is now using namespaces, so
'SimpleSAML_Configuration' becomes 'SimpleSAML\Configuration'
'SimpleSAML_Metadata_MetaDataStorageSource' becomes
'SimpleSAML\Metadata\MetaDataStorageSource'

Change-Id: Icfe4fac03e8857688b1128ef0884ebde8c0d40a6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 997550f96572ce2d1bb89f910143785a8bbf657f)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.