Mahara

Changes to subtheme starter to inherit parent theme styles properly again

Bug #1896703 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Evonne Cheung
Mahara 20.10.0

Bug Description

Some changes were made to the theme folder structure that resulted in not all styles being inherited properly from the parent theme. Evonne found how to correct that.

See original description
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11306

Kristina Hoeppner (kris-hoeppner)
description: updated
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
milestone: 20.10.0 → 20.10rc2
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11306
Committed: https://git.mahara.org/mahara/mahara/commit/4bb465b23e3f243acb034e65a6a0911ccd223035
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4bb465b23e3f243acb034e65a6a0911ccd223035
Author: Evonne <email address hidden>
Date: Wed Sep 23 14:03:14 2020 +1200

Bug 1896703 Subtheme starter theme updates

Makes parent and grandparent inheritance work for subtheme
starter theme. Font of parent theme is also inherited correctly.

behatnotneeded

Change-Id: Icda348282947d5697679106c334d8fc3c7e9566a

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11356

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11356
Committed: https://git.mahara.org/mahara/mahara/commit/33fb6597e533cea1cbcb971b5879fff8a7013b42
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 33fb6597e533cea1cbcb971b5879fff8a7013b42
Author: Evonne <email address hidden>
Date: Wed Sep 23 14:03:14 2020 +1200

Bug 1896703 Subtheme starter theme updates

Makes parent and grandparent inheritance work for subtheme
starter theme. Font of parent theme is also inherited correctly.

behatnotneeded

Change-Id: Icda348282947d5697679106c334d8fc3c7e9566a
(cherry picked from commit 4bb465b23e3f243acb034e65a6a0911ccd223035)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10rc2 → 20.10.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.