Retractable option not available any more in 'Edit' mode

Bug #1898478 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.10
Fix Released
Medium
Unassigned
20.04
Fix Released
Medium
Unassigned
20.10
Fix Released
Medium
Unassigned

Bug Description

This is a regression.

The retractable option in 'Edit' mode is not available any more, thus making it more difficult for people to deal with long blocks or see what the end result is in display mode.

Tags: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11333

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

To test:

- Have a page and a block in it
- go into the page 'Edit mode'

- configure the block and set the 'Retractable' field to 'No' and save
- the retract arrow should not be displayed in the title and the block content is expanded

- configure the block and set the 'Retractable' field to 'Yes' and save
- the retract arrow is displayed in the title and the block content is expanded

- configure the block and set the 'Retractable' field to 'Automatically retract' and save
- the retract arrow is displayed in the title and the block content is collapsed

for these three option make sure they works as expected when adding a new block, editing an existing one and when refreshing the page

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

This is still not working when the block is changed but the page is not reloaded.
For testing:

- Have a block in a page
- edit the page and click on the configuration of the block
- set the Retractable field as 'No'
- save and reload the page
- click on the configuration button for the block again and set the Retractable field to 'yes' and save
- click on the retract arrow on the block

The block content is hidden but the block is not being resized leaving an empty block with the same size it had before being collapsed
There is another bug report to fix this issue https://bugs.launchpad.net/mahara/+bug/1898809

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11333
Committed: https://git.mahara.org/mahara/mahara/commit/b49df631d3cff3abd005cf072b87aca03fee3360
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit b49df631d3cff3abd005cf072b87aca03fee3360
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 6 18:58:01 2020 +1300

Bug 1898478: Retractable option in 'Edit' mode

Make retractable arrow visible and functional in the view's edit mode.
It has to allow to be move around while retracted so it's easier
to move big blocks

Change-Id: I44f92b1e57ebe4778a19bd8f6768fe1c7f6480cc

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11341

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11341
Committed: https://git.mahara.org/mahara/mahara/commit/00196d06516464c34e8b7be7948be248b49780a3
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 20.10_STABLE

commit 00196d06516464c34e8b7be7948be248b49780a3
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 6 18:58:01 2020 +1300

Bug 1898478: Retractable option in 'Edit' mode

Make retractable arrow visible and functional in the view's edit mode.
It has to allow to be move around while retracted so it's easier
to move big blocks

Change-Id: I44f92b1e57ebe4778a19bd8f6768fe1c7f6480cc
(cherry picked from commit b49df631d3cff3abd005cf072b87aca03fee3360)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11342

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11342
Committed: https://git.mahara.org/mahara/mahara/commit/70afe2a04a5e0b4fef61dac4c174003298a9aa97
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 20.04_STABLE

commit 70afe2a04a5e0b4fef61dac4c174003298a9aa97
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 6 18:58:01 2020 +1300

Bug 1898478: Retractable option in 'Edit' mode

Make retractable arrow visible and functional in the view's edit mode.
It has to allow to be move around while retracted so it's easier
to move big blocks

Change-Id: I44f92b1e57ebe4778a19bd8f6768fe1c7f6480cc
(cherry picked from commit b49df631d3cff3abd005cf072b87aca03fee3360)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11343

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11343
Committed: https://git.mahara.org/mahara/mahara/commit/4a6c6f487cac757cf9d3e8fd8785d16eff486aa8
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 4a6c6f487cac757cf9d3e8fd8785d16eff486aa8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 6 18:58:01 2020 +1300

Bug 1898478: Retractable option in 'Edit' mode

Make retractable arrow visible and functional in the view's edit mode.
It has to allow to be move around while retracted so it's easier
to move big blocks

Change-Id: I44f92b1e57ebe4778a19bd8f6768fe1c7f6480cc
(cherry picked from commit b49df631d3cff3abd005cf072b87aca03fee3360)
(cherry picked from commit 70afe2a04a5e0b4fef61dac4c174003298a9aa97)

Robert Lyon (robertl-9)
no longer affects: mahara/21.04
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.