Support fingerprint identification in the driver of Synaptics fingerprint reader

Bug #1905600 reported by Shengyao Xue
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
High
Shengyao Xue
libfprint (Ubuntu)
Fix Released
High
Marco Trevisan (Treviño)
Focal
Fix Released
High
Marco Trevisan (Treviño)
Groovy
Fix Released
High
Marco Trevisan (Treviño)

Bug Description

[Impact]

On Ubuntu 20.04, with Synaptics fingerprint reader, users can use one fingerprint to login system, but if users add more fingerprints, they still can only one of those to login, other fingerprints do not work.

To fix this issue, we need support fingerprint identification in the driver of Synaptics fingerprint reader, by backport this libfprint commit to Focal:
https://gitlab.freedesktop.org/libfprint/libfprint/commit/e27b65c9

[Test Case]

I tried backport the commit above to libfprint (1:1.90.2+tod1-0ubuntu1~20.04.2) in Focal and tested on 3 ThinkPads(both use the 06cb:00bd Synaptics fingerprint reader), the multiple fingerprints works well.

We have other OEM platforms with Synaptics fingerprint reader, we can use it to validate the changes if needed.

[Regression Potential]

the commit comes from Synaptics' engineer, just affects one file: libfprint/drivers/synaptics/synaptics.c, and only add identification support in that file, so the regression potential should be low.

Changed in oem-priority:
importance: Undecided → High
assignee: nobody → Shengyao Xue (xueshengyao)
Changed in oem-priority:
status: New → In Progress
Changed in libfprint (Ubuntu):
status: New → In Progress
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Undecided → High
Changed in libfprint (Ubuntu Groovy):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Undecided → High
status: New → In Progress
Changed in libfprint (Ubuntu Focal):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libfprint - 1:1.90.3+tod1-0ubuntu2

---------------
libfprint (1:1.90.3+tod1-0ubuntu2) hirsute; urgency=medium

  * debian/gbp.conf: Include debian's GNOME team preferred settings
  * debian/patches (upstream cherry-picks):
    - Properly handle aes3k devices, resubmitting commands.
      This also needs proper commands cancellation (LP: #1897613)
    - Add support for new Synaptics devices IDs (LP: #1905593)
    - Fix vfs301 verification using device pointer on callbacks (LP: #1905597)
    - Ensure we do not waste power for unsupported devices (LP: #1905603)
    - Add identification support to synaptics driver.
      It allows to unlock / log-in with any finger. (LP: #1905600)

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 25 Nov 2020 19:18:20 +0100

Changed in libfprint (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Rex Tsai (chihchun) wrote :

Marco,

CE would also like to SRU this patch to support unlock / log-in with any finger in focal. Can you help with this or should Shengyao propose a change for focal?

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Shengyao, or anyone else affected,

Accepted libfprint into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.3+tod1-0ubuntu2~20.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libfprint (Ubuntu Groovy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-groovy
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Shengyao, or anyone else affected,

Accepted libfprint into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.2+tod1-0ubuntu1~20.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libfprint (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Shengyao Xue (xueshengyao) wrote :

tested new version in -proposed, the multiple finger support works fine. tag verification
 done.

tags: added: verification-done verification-done-focal verification-done-groovy
removed: verification-needed verification-needed-focal verification-needed-groovy
Changed in oem-priority:
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Shengyao, or anyone else affected,

Accepted libfprint into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.3+tod1-0ubuntu2~20.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-groovy
removed: verification-done verification-done-groovy
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Shengyao, or anyone else affected,

Accepted libfprint into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.2+tod1-0ubuntu1~20.04.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-focal
removed: verification-done-focal
Rex Tsai (chihchun)
Changed in oem-priority:
status: Fix Released → In Progress
assignee: Shengyao Xue (xueshengyao) → Bin Li (binli)
Revision history for this message
Bin Li (binli) wrote :

Tested new package from focal-proposed on ThinkPad X1 Nano, it works fine. Thanks!

Upgrade: libfprint-2-2:amd64 (1:1.90.2+tod1-0ubuntu1~20.04.2, 1:1.90.2+tod1-0ubuntu1~20.04.4)

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Bin Li (binli) wrote :

Tested new package from groovy-proposed on ThinkPad X1 Nano, it works fine. Thanks!

Upgrade: libfprint-2-2:amd64 (1:1.90.3+tod1-0ubuntu1, 1:1.90.3+tod1-0ubuntu2~20.10.2)

tags: added: verification-done-groovy
removed: verification-needed-groovy
tags: added: verification-done
removed: verification-needed
Changed in oem-priority:
status: In Progress → Fix Committed
Changed in oem-priority:
status: Fix Committed → In Progress
assignee: Bin Li (binli) → Shengyao Xue (xueshengyao)
Revision history for this message
Alex Tu (alextu) wrote : Re: [Bug 1905600] Re: Support fingerprint identification in the driver of Synaptics fingerprint reader

Hi Shengyao,

Why you set state to in progress?

Did you find something regression ?

Shengyao Xue <email address hidden> 於 2021年1月25日 週一 下午3:50 寫道:

> ** Changed in: oem-priority
> Status: Fix Committed => In Progress
>
> ** Changed in: oem-priority
> Assignee: Bin Li (binli) => Shengyao Xue (xueshengyao)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1905600
>
> Title:
> Support fingerprint identification in the driver of Synaptics
> fingerprint reader
>
> Status in OEM Priority Project:
> In Progress
> Status in libfprint package in Ubuntu:
> Fix Released
> Status in libfprint source package in Focal:
> Fix Committed
> Status in libfprint source package in Groovy:
> Fix Committed
>
> Bug description:
> [Impact]
>
> On Ubuntu 20.04, with Synaptics fingerprint reader, users can use one
> fingerprint to login system, but if users add more fingerprints, they
> still can only one of those to login, other fingerprints do not work.
>
> To fix this issue, we need support fingerprint identification in the
> driver of Synaptics fingerprint reader, by backport this libfprint commit
> to Focal:
> https://gitlab.freedesktop.org/libfprint/libfprint/commit/e27b65c9
>
> [Test Case]
>
> I tried backport the commit above to libfprint
> (1:1.90.2+tod1-0ubuntu1~20.04.2) in Focal and tested on 3
> ThinkPads(both use the 06cb:00bd Synaptics fingerprint reader), the
> multiple fingerprints works well.
>
> We have other OEM platforms with Synaptics fingerprint reader, we can
> use it to validate the changes if needed.
>
> [Regression Potential]
>
> the commit comes from Synaptics' engineer, just affects one file:
> libfprint/drivers/synaptics/synaptics.c, and only add identification
> support in that file, so the regression potential should be low.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/oem-priority/+bug/1905600/+subscriptions
>

Revision history for this message
Shengyao Xue (xueshengyao) wrote :

@Alex, because the new libfprint do not lands to focal-updates from focal-proposed for weeks.

There are some bugs not verified:

https://bugs.launchpad.net/ubuntu/+source/libfprint/+bug/1897613
https://bugs.launchpad.net/ubuntu/+source/libfprint/+bug/1908107

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libfprint - 1:1.90.3+tod1-0ubuntu2~20.10.2

---------------
libfprint (1:1.90.3+tod1-0ubuntu2~20.10.2) groovy; urgency=medium

  * debian/patches:
    - image-device: Delay completion until deactivation (LP: #1897613)
    - Support more synaptics devices PIDs (LP: #1905593)
    - Ensure we properly handle references of prints galleries (LP: #1908107)

libfprint (1:1.90.3+tod1-0ubuntu2~20.10.1) groovy; urgency=medium

  * debian/gbp.conf:
    - Include debian's GNOME team preferred settings
    - Prepare for groovy branching
  * debian/patches (upstream cherry-picks):
    - Properly handle aes3k devices, resubmitting commands.
      This also needs proper commands cancellation (LP: #1897613)
    - Add support for new Synaptics devices IDs (LP: #1905593)
    - Fix vfs301 verification using device pointer on callbacks (LP: #1905597)
    - Ensure we do not waste power for unsupported devices (LP: #1905603)
    - Add identification support to synaptics driver.
      It allows to unlock / log-in with any finger. (LP: #1905600)

 -- Marco Trevisan (Treviño) <email address hidden> Mon, 14 Dec 2020 19:19:45 +0100

Changed in libfprint (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for libfprint has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libfprint - 1:1.90.2+tod1-0ubuntu1~20.04.4

---------------
libfprint (1:1.90.2+tod1-0ubuntu1~20.04.4) focal; urgency=medium

  * debian/patches:
    - image-device: Delay completion until deactivation (LP: #1897613)
    - Support more synaptics devices PIDs (LP: #1905593)
    - Ensure we properly handle references of prints galleries (LP: #1908107)

libfprint (1:1.90.2+tod1-0ubuntu1~20.04.3) focal; urgency=medium

  * debian/patches (upstream cherry-picks):
    - Properly handle aes3k devices, resubmitting commands.
      This also needs proper commands cancellation (LP: #1897613)
    - Add support for new Synaptics devices IDs (LP: #1905593)
    - Fix vfs301 verification using device pointer on callbacks (LP: #1905597)
    - Ensure we do not waste power for unsupported devices (LP: #1905603)
    - Add identification support to synaptics driver.
      It allows to unlock / log-in with any finger. (LP: #1905600)

 -- Marco Trevisan (Treviño) <email address hidden> Mon, 14 Dec 2020 19:28:09 +0100

Changed in libfprint (Ubuntu Focal):
status: Fix Committed → Fix Released
Changed in oem-priority:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.