When you copy a collection with SmartEvidence, all annotations come along as well

Bug #1911824 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Doris Tam
21.04
Fix Released
High
Unassigned
21.10
Fix Released
High
Unassigned

Bug Description

When your collection contains SmartEvidence, the annotation content (but not the feedback) and the annotation is set back to 'Ready for assessment'.

So as not to copy somebody else's reflections, it would be better to not copy annotations along at all.

When an account holder copies a collection that isn't owned by them containing SmartEvidence, the collection copy should not have any annotation blocks copied over.

However, when the author of a collection containing SmartEvidence duplicates the collection, the copy shall have the annotation copied over from the original collection as the content inside annotation blocks reflect their own work.

To replicate:

1. Create a collection with at least one page and SmartEvidence activated.
2. Add an annotation to one standard.
3. Make the collection available and allow copying.
4. Log in as somebody else and view the collection.
5. Copy the entire collection.
6. Go to the SmartEvidence page.
Expected result: The SmartEvidence map is empty and there are no annotation blocks on pages.
Actual result: The annotation blocks are still there and the status on the SmartEvidence page for them is 'Ready for assessment', i.e. the blue circle.

Doris Tam (doristam)
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11524

Doris Tam (doristam)
Changed in mahara:
status: Confirmed → In Progress
Doris Tam (doristam)
description: updated
description: updated
Changed in mahara:
milestone: 21.04.0 → 21.04.1
Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Confirmed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11524
Committed: https://git.mahara.org/mahara/mahara/commit/cba392691da34fdf94b6053ebf57db86299a0fe3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cba392691da34fdf94b6053ebf57db86299a0fe3
Author: Doris Tam <email address hidden>
Date: Tue Jan 26 11:27:34 2021 +1300

Bug 1911824: Change the copy setting for artefact annotation to 'nocopy'

Check that $evidences exist in case there exist evidenviews but no evidence blocks to copy

if the only block on a view is an annotation block, then make a check to not get the sql to run copies
which will result in error as there are no artefacts to copy.

Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11778

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11782

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11778
Committed: https://git.mahara.org/mahara/mahara/commit/d31993ddc5dd251e52bdb46c26eb6f5fee4524f2
Submitter: Lisa Seeto (<email address hidden>)
Branch: 21.04_STABLE

commit d31993ddc5dd251e52bdb46c26eb6f5fee4524f2
Author: Doris Tam <email address hidden>
Date: Tue Jan 26 11:27:34 2021 +1300

Bug 1911824: Change the copy setting for artefact annotation to 'nocopy'

Check that $evidences exist in case there exist evidenviews but no evidence blocks to copy

if the only block on a view is an annotation block, then make a check to not get the sql to run copies
which will result in error as there are no artefacts to copy.

Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33
(cherry picked from commit cba392691da34fdf94b6053ebf57db86299a0fe3)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11782
Committed: https://git.mahara.org/mahara/mahara/commit/9969d6098b8f02a8a4d7a5d8fbfbeb76ae512a21
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9969d6098b8f02a8a4d7a5d8fbfbeb76ae512a21
Author: Robert Lyon <email address hidden>
Date: Mon May 17 10:28:59 2021 +1200

Bug 1911824: Putting back the function that stopped feedback duplication

On the original page when copying it

To test:
- create an annotation page
- add two feedbacks to the annotation
- copy page
- view original page

Before patch
- now see there are four annotations

After patch
- still see two annotations

Change-Id: I435a53e59e20d44ad186671a7f03df199cb7d423
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.