/dev/null inside the chroot is not created by /usr/share/doc/scponly/setup_chroot/setup_chroot.sh.gz

Bug #191422 reported by Albrecht Mühlenschulte
2
Affects Status Importance Assigned to Milestone
scponly (Debian)
Fix Released
Unknown
scponly (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: scponly

As mentioned in the scponly-wiki http://sublimation.org/scponly/wiki/index.php/FAQ#Chroot_and_Debian

/usr/share/doc/scponly/setup_chroot/setup_chroot.sh.gz does not create the necessary dev/null inside the changeroot.

4.6-1.1 @ edgy eft

Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :

Fix.

Revision history for this message
Daniel Holbach (dholbach) wrote :

To get your fix included in Ubuntu, it would help if you tried transforming it into a debdiff (http://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff) and submit it for review (http://wiki.ubuntu.com/SponsorshipProcess). If you prefer somebody else to do that, that's fine - please just indicate if you're available to do that.

Changed in scponly:
assignee: nobody → a7p
Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :

Someone of Debian suggests to remove the dependency to /dev/null for the sftp-part of scponly, so that the script does not have to be altered (see Debian bug-report).

Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :

Don't know if I did everything right - if not, I'd be happy to learn something..

Changed in scponly:
assignee: a7p → ubuntu-universe-sponsors
status: New → Fix Committed
Revision history for this message
Maia Everett (linneris) wrote :

* Distribution in debian/changelog should be "hardy" and the bug closure syntax for Ubuntu is "LP: #xxx" rather than "Closes: #xxx".
* Please integrate your original patch as a separate patch in debian/patches inside the debdiff, using a patch system like dpatch or quilt, instead of directly modifying the original source. Refer to the packaging guide for details/

Please resubscribe u-u-s after reuploading the debdiff.

Changed in scponly:
assignee: ubuntu-universe-sponsors → a7p
status: Fix Committed → Incomplete
Changed in scponly:
status: Unknown → New
Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :

Integrated the patch via dpatch. Am not sure if the patch will be applied correctly, but I hope everything is all right now.

Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :

sry, wrong file. Hope there are no mistakes in debian/rules - used dpatch for the first time.

Changed in scponly:
assignee: a7p → ubuntu-universe-sponsors
status: Incomplete → Fix Committed
Changed in scponly:
assignee: ubuntu-universe-sponsors → nobody
status: Fix Committed → Confirmed
Revision history for this message
Maia Everett (linneris) wrote :

Looks like the debdiff is corrupted, as there are no changes to debian/rules and some "testpatch" stuff. Please redownload the Debian version and regenerate the debdiff.

Also, when submitting changes for sponsoring, set the bug status to Confirmed rather than Fix Committed.

Changed in scponly:
assignee: nobody → a7p
status: Confirmed → Incomplete
Revision history for this message
Maia Everett (linneris) wrote :

Also, add dpatch to build-dependencies.

Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :
Changed in scponly:
assignee: a7p → ubuntu-universe-sponsors
status: Incomplete → Confirmed
Revision history for this message
Luke Yelavich (themuso) wrote :

Please subscribe, not assign, ubuntu-universe-sponsors next time.

Changed in scponly:
assignee: ubuntu-universe-sponsors → themuso
status: Confirmed → In Progress
Revision history for this message
Luke Yelavich (themuso) wrote :

Please mention in the changelog that you have updated/changed the maintainer as per the Debian Maintainer Field specification. You can find mroe information here: https://wiki.ubuntu.com/DebianMaintainerField.

Please upload a new debdiff, and re-subscribe ubuntu-universe-sponsors when done.

Changed in scponly:
assignee: themuso → nobody
status: In Progress → Incomplete
Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :
Changed in scponly:
assignee: nobody → a7p
status: Incomplete → Confirmed
assignee: a7p → nobody
Revision history for this message
Maia Everett (linneris) wrote :

I'm sorry for making you upload a version with dpatch.

After some discussion on IRC, it was decided that directly modifying the source is better for this particular package. Well, at least you learned something new :).

Please reupload your original debdiff for Hardy, which doesn't use dpatch, but with the changes suggested by me and Luke Yelavich:

- change distribution in debian/changelog to "hardy";
- mention that you modified the maintainer field.

After that, I will sponsor it.

Changed in scponly:
importance: Undecided → Low
status: Confirmed → Incomplete
Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :

here we go again ... *g*

Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :

here we go again ... *g*

Changed in scponly:
status: Incomplete → Confirmed
Revision history for this message
Maia Everett (linneris) wrote :

Looks fine to me now. I'm looking into it.

Changed in scponly:
assignee: nobody → sikon
status: Confirmed → In Progress
Revision history for this message
Maia Everett (linneris) wrote :

Fix did not work for me. See http://paste.ubuntu.com/4611/ for the full output.

mknod: missing operand after `/home/testuser/dev/null'
Try `mknod --help' for more information.

Also, not a blocker, but you might prefer to use mkdir -p to avoid the error message from mkdir.

Please reupload and resubscribe u-u-s.

Changed in scponly:
assignee: sikon → a7p
status: In Progress → Incomplete
Revision history for this message
Albrecht Mühlenschulte (a7p) wrote :
Changed in scponly:
assignee: a7p → nobody
status: Incomplete → Confirmed
Revision history for this message
Maia Everett (linneris) wrote :

Uploaded, thanks for your work (and patience ;)).

Please propose it to Debian as well!

Changed in scponly:
assignee: nobody → sikon
status: Confirmed → In Progress
assignee: sikon → nobody
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package scponly - 4.6-1.2ubuntu1

---------------
scponly (4.6-1.2ubuntu1) hardy; urgency=low

  * patched setup_chroot.sh.in so that dev/null get's created in the chroot
    (LP: #191422). OpenSSH for scponly requires a dev/null in the execution
    enviroment, this was not the fact in the past and may change in the future.
  * changed Maintainer-Field to MOTU and introduced XSBC-Original-Maintainer
    with former maintainer.

 -- Albrecht Muehlenschulte <email address hidden> Fri, 15 Feb 2008 16:06:01 +0100

Changed in scponly:
status: Fix Committed → Fix Released
Changed in scponly (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.