AngularJS egOrg tests fail

Bug #1915326 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.10
Fix Released
Low
Unassigned
3.11
Fix Released
Low
Unassigned

Bug Description

Affects all versions of Eg including commit 14989c3089b0f135a1ce53a16c0c6ea4d8890890

Bug 1901760 fixed the issue where browsers that don't support SharedWorkers failed to work due to JS errors, but now 12 egOrg npm tests fail with a Reference Error for 'lf' in isCacheGood()

Below is an example of the failing test output, all 12 stack traces are basically the same:

1) should provide get by ID
     egOrg
     ReferenceError: lf is not defined
    at Object.o.isCacheGood (build/js/core.bundle.js:1:67515)
    at Object.i.absorbList (build/js/core.bundle.js:1:16006)
    at Object.i.absorbTree (build/js/core.bundle.js:1:15709)
    at Object.orgTree (test/data/eg_mock.js:48:15)
    at mkTree (test/unit/egOrg.js:8:30)
    at UserContext.<anonymous> (test/unit/egOrg.js:12:9)
    at Object.a [as invoke] (build/js/vendor.bundle.js:6:20097)
    at UserContext.WorkFn (node_modules/angular-mocks/angular-mocks.js:3191:20)
Error: Declaration Location
    at window.inject.angular.mock.inject (node_modules/angular-mocks/angular-mocks.js:3154:25)
    at Suite.<anonymous> (test/unit/egOrg.js:11:36)
    at test/unit/egOrg.js:3:1

Jason Boyer (jboyer)
Changed in evergreen:
importance: Undecided → Low
tags: added: angularjs
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
milestone: none → 3.11-beta
assignee: Galen Charlton (gmc) → nobody
tags: added: pullrequest
Revision history for this message
Jason Boyer (jboyer) wrote :

Works as expected! Signoff and followup to completely quash the remaining noise (404 for an abs path, background worker complaining) here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1915326_signoff_moar_hush / working/user/jboyer/lp1915326_signoff_moar_hush

Revision history for this message
Galen Charlton (gmc) wrote :

Thanks, Jason! Follow-up tested and cross-signed-off branch pushed to user/gmcharlt/lp1915326_signoff

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks so much, Galen and Jason! Pushed to rel_3_9 and above.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.