Making theming of buttons more efficient

Bug #1915469 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Evonne Cheung

Bug Description

Buttons in list-group-item that float right and stick to the top
hav various breakpoints that do different things, so redoing them
to use flex in a more consistent way and reduce the need for many
overrides in the theme.

Expected behaviour:
In list-group-items, edit and delete buttons etc stick to the top
right corner of that list-group item at all browser widths, even
if title wraps.

Actual behaviour:
The buttons stick at the top when in desktop width, then unstick
on tablet view, and some align to left at some breakpoint, and when
title wraps it would unstick at desktop width, or neglect the
user icon if there is one to the left of the title.

Additionally, improving the CSS for input select, drop-down select, switches, etc. buttons to prevent too many overrides when the buttons are styled more graphically.

Tags: newfeature
Revision history for this message
Gold (gold.catalyst) wrote :

Locating the Copy Page button for Template Pages on a Group involved a few conditions to be met.

* The Page needs to be owned by a Group
  * Goto a Group and open the Pages and collections tab
  * Click + Add > Page
* The Page needs to be a Template
  * Page (edit)
  * Expand Advanced
  * Set Template to Yes
  * Save the Page
* Set Access and copying on the Page
  * On the Pages and collections tab of the Group click Manage Access (the padlock icon) for the page
  * Ensure the 'Shared with' settings allow members of the Group access
  * Expand Advanced Options
  * Set Allow copying to Yes
  * Save the Page

At this point on the Groups About tab the page should appear under the Group portfolios and have the Copy Page button available to it.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11545
Committed: https://git.mahara.org/mahara/mahara/commit/c47b0ddf6fcab5ba43be5a8123636e1bce2ca2ad
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit c47b0ddf6fcab5ba43be5a8123636e1bce2ca2ad
Author: Evonne <email address hidden>
Date: Fri Jan 29 12:14:02 2021 +1300

Bug 1915469 Flex titles and buttons

Buttons in list-group-item that float right and stick to the top
has various breakpoints that do different things, so redoing them
to use flex in a more consistent way and reduce the need for many
overrides in the theme.

Expected behaviour:
In list-group-items, edit and delete buttons etc stick to the top
right corner of that list-group item at all browser widths, even
if title wraps.

Actual behaviour:
The buttons stick at the top when in desktop width, then unstick
on tablet view, and some align to left at some breakpoint, and when
title wraps it would unstick at desktop width, or neglect the
user icon if there is one to the left of the title.

Also added new variable for user-icons too easily change out the
border-radius.

* Refactored selectors for Behat tests to locate the button area.
* Restore the metadata div if it is a private message (Annotations)
* Restore comment-text to commentlist.tpl for behat.
* Journals defaults to auto focus on first Journal title for multi-journal users.

behatnotneeded

Change-Id: I6a51e5e9597c3138867a588552bfc38141be3db3

Lisa Seeto (lisaseeto)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11744

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.