Mahara

Use dart-sass instead of node-sass for gulp make css

Bug #1918357 reported by Doris Tam
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Doris Tam
Mahara 22.10.0

Bug Description

Node-sass uses Lib-sass which is deprecated.

Node-sass is deprecated and bootstrap recommends dart-sass over it for the new version to be compatible with upgrading the library.

This is related to https://bugs.launchpad.net/mahara/+bug/1918373 with reference to https://getbootstrap.com/docs/5.0/getting-started/build-tools/#sass for future purposes when we have BS5

https://getbootstrap.com/docs/5.0/getting-started/build-tools/#tooling-setup

See original description
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11607

Revision history for this message
Doris Tam (doristam) wrote :

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

description: updated
Revision history for this message
Doris Tam (doristam) wrote :

https://sass-lang.com/documentation/cli/migrator - attempting to use sass-migrator to get to dart-sass as the syntax is different

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11813

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11817

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 21.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12108

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 21.10.0 → 22.04.0
Doris Tam (doristam)
description: updated
Doris Tam (doristam)
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
Doris Tam (doristam)
Changed in mahara:
milestone: 22.04.0 → 22.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12107
Committed: https://git.mahara.org/mahara/mahara/commit/1518d026dc3d62ad84347f5cbba1ca124954569d
Submitter: "Doris Tam <email address hidden>"
Branch: main

commit 1518d026dc3d62ad84347f5cbba1ca124954569d
Author: Doris Tam <email address hidden>
Date: Mon May 31 16:54:49 2021 +1200

Bug 1918357: Removing node-sass a dependency by gulp-sass

Change-Id: I39d0918d176f571910c80dbbe3aa077f412426da

Doris Tam (doristam)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/12108
Committed: https://git.mahara.org/mahara/mahara/commit/8590747cda81e5ba97a1ac80d847b86518500575
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 8590747cda81e5ba97a1ac80d847b86518500575
Author: Doris Tam <email address hidden>
Date: Tue Jun 1 12:32:43 2021 +1200

Bug 1915975: Upgrade bootstrap4 to bootstrap5

Adding compatibility to the new sass:
-> converting node-sass to dart-sass

- remove old bootstrap4 repo that wasn't used for anything
- `data-...` classes updated to `data-bs-...`
- updated bootstrap min.js files @ htdocs/lib/bootstrap/assets/javascripts
not sure what they are needed for yet
- the date time picker is not related to bootstrap and is a library of its own
and doesn't have a bootstrap5 version yet
Related to Bug 1918357

Change-Id: Ic0e18a648b6318d90e8d0d2f863de388def237da

Doris Tam (doristam)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.