Mahara

LTI accessing pages of collection when link is for progresscompletion.php page

  1. Series 21.04
  2. Bug #1918367
Bug #1918367 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
20.10
Fix Released
High
Unassigned
Mahara 20.10.1
21.04
Fix Released
High
Robert Lyon
Mahara 21.04.0

Bug Description

We made a fix in Bug #1891575 for allowing the LTI access to any page in the collection but we didn't take into account the collection/progresscompletion.php page (if enabled) as that ID is not a view ID but the collection ID

We need to adjust the check so that we can handle this situation

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11608

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11608
Committed: https://git.mahara.org/mahara/mahara/commit/bbf1525efffa52c47373ae08d42a2c6547662912
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit bbf1525efffa52c47373ae08d42a2c6547662912
Author: Robert Lyon <email address hidden>
Date: Wed Mar 10 16:31:52 2021 +1300

Bug 1918367: progresscompletion.php page work for lit.canviewview

Change-Id: I10347e1500115a7614d9ca8e3b44879ede4e02a3
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11679

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11744

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11679
Committed: https://git.mahara.org/mahara/mahara/commit/216bb9ccebb2d90043f0caeb80f8e5ff595cc148
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 216bb9ccebb2d90043f0caeb80f8e5ff595cc148
Author: Robert Lyon <email address hidden>
Date: Wed Mar 10 16:31:52 2021 +1300

Bug 1918367: collections work for lit.canviewview

Change-Id: I10347e1500115a7614d9ca8e3b44879ede4e02a3
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bbf1525efffa52c47373ae08d42a2c6547662912)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.