Bug #1926298 “Segfault added in the recent changes” : Bugs : update-notifier package : Ubuntu

Sebastien Bacher (seb128) on 2021-04-27

Changed in update-notifier (Ubuntu):
importance:	Undecided → High

Dan Bungert (dbungert) on 2021-04-27

tags:	added: fr-1314
Changed in update-notifier (Ubuntu):
assignee:	nobody → Dan Bungert (dbungert)

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-04-27:

#1

Marking confirmed as I can see a segfault, but mine looks a little different:

Thread 1 "update-notifier" received signal SIGSEGV, Segmentation fault.
show_next_hook (hooks=0x555555778340 = {...}, ta=<optimized out>, ta=<optimized out>) at hooks.c:376
376 gtk_widget_hide(priv->button_next);
(gdb) bt
#0 show_next_hook (hooks=0x555555778340 = {...}, ta=0x5555556c9000, ta=<optimized out>) at hooks.c:376
#1 0x000055555555efdc in show_hooks (focus_on_map=0, ta=0x5555556c9000) at hooks.c:609
#2 check_update_hooks (ta=0x5555556c9000) at hooks.c:858
#3 0x000055555555f268 in hook_tray_icon_init (ta=<optimized out>) at hooks.c:969
#4 0x000055555555c933 in tray_icons_init (un=0x5555556e4f70) at update-notifier.c:447
#5 0x00007ffff7351e38 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#6 0x00007ffff735174f in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7 0x00007ffff73a4c68 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#8 0x00007ffff7350db3 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#9 0x00007ffff7a4517d in gtk_main () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x000055555555c0f5 in main (argc=<optimized out>, argv=<optimized out>) at update-notifier.c:649

I like your suggestion to use g_find_program_in_path and plan to use that if at all possible.

Changed in update-notifier (Ubuntu):
status:	New → Confirmed

Dan Bungert (dbungert) on 2021-04-27

Changed in update-notifier (Ubuntu):
status:	Confirmed → In Progress

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-04-27:

#2

update-notifier-1-3.192.41.debdiff Edit (2.0 KiB, text/plain)

Root cause:
The goto out for cleanup can skip a variable initialization, so in some cases we
crash on if(pathdirs) g_strfreev(pathdirs); because pathdirs is declared too
late and, in that code flow, never initialized.

We could thus also fix this by ensuring that pathdirs is properly initialized
at the beginning of the function, but removing the reimplementation of
g_find_program_in_path is the superior solution.

Attached is my proposed fix, however I don't think we should upload yet since there appear to be some parallel work going on in https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315

Revision history for this message

Sebastien Bacher (seb128) wrote on 2021-04-27:

#3

Thanks Dan, the explanation of the issue and simplification as a solution are making sense, I've tested locally the patch and confirmed it resolves the segfault. The other bug you mention has its fix uploaded so nothing is preventing us to queue another upload now

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-04-27:

#4

MP: https://code.launchpad.net/~dbungert/update-notifier/+git/update-notifier/+merge/401901

Changed in update-notifier (Ubuntu):
status:	In Progress → Confirmed

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2021-04-27:

#5

The attachment "update-notifier-1-3.192.41.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags:

added: patch

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-04-27:

#6

It is a patch but I'm not looking for a sponsor at this time, since it's going thru the MP.

tags:

removed: patch

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-04-27:

#7

_usr_bin_update-notifier.1000.crash Edit (1.4 MiB, text/plain)

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-04-28:

#8

Download full text (8.5 KiB)

I manually retraced the crash file Dan provided and the results follow:

Stacktrace:
#0 0x00007f3250972202 in g_strfreev (str_array=<optimized out>) at ../../../glib/gstrfuncs.c:2552
         i = 0
#1 g_strfreev (str_array=0x69726f6972500a67) at ../../../glib/gstrfuncs.c:2546
         i = <optimized out>
#2 0x0000562c680f57ff in hook_command_exists (cmd=<optimized out>) at hooks.c:137
         cargv = 0x562c6a3edc70
         result = 1
         unquoted = 0x562c6a3cfb50 "/bin/true"
         error = 0x0
         cargc = 1
         pathdirs = 0x69726f6972500a67
         result = <optimized out>
         unquoted = <optimized out>
         cargv = <optimized out>
         error = <optimized out>
         out = <optimized out>
         cargc = <optimized out>
         pathdirs = <optimized out>
         i = <optimized out>
         pathdir = <optimized out>
         fname = <optimized out>
#3 is_hook_relevant (hook_file=hook_file@entry=0x562c6a4c0073 "bug") at hooks.c:717
         res = <optimized out>
         filename = 0x562c6a2277e0 "/var/lib/update-notifier/user.d/bug"
         f = <optimized out>
         rfc822 = 0x562c6a19d540
         b = <optimized out>
#4 0x0000562c680f6b65 in check_update_hooks (ta=0x562c6a40e1b0) at hooks.c:781
         new_mtime = <optimized out>
         elm = <optimized out>
         hf = <optimized out>
         dir = 0x562c6a185660
         hook_file = 0x562c6a4c0073 "bug"
         priv = 0x562c6a238bc0
         unseen_count = 0
         __PRETTY_FUNCTION__ = "check_update_hooks"
#5 0x0000562c680f7268 in hook_tray_icon_init (ta=<optimized out>) at hooks.c:969
         priv = <optimized out>
#6 0x0000562c680f4933 in tray_icons_init (un=0x562c6a1ddd30, un@entry=<error reading variable: value has been optimized out>) at update-notifier.c:447
No locals.
#7 0x00007f3250956e38 in g_timeout_dispatch (source=0x562c6a195330, callback=<optimized out>, user_data=<optimized out>) at ../../../glib/gmain.c:4889
         timeout_source = 0x562c6a195330
         again = <optimized out>
#8 0x00007f325095674f in g_main_dispatch (context=0x562c6a0d7060) at ../../../glib/gmain.c:3337
         dispatch = 0x7f3250956e20 <g_timeout_dispatch>
         prev_source = 0x0
         begin_time_nsec = 0
         was_in_call = 0
         user_data = 0x562c6a1ddd30
         callback = 0x562c680f4870 <tray_icons_init>
         cb_funcs = <optimized out>
         cb_data = 0x562c6a1bedc0
         need_destroy = <optimized out>
         source = 0x562c6a195330
         current = 0x562c6a1317c0
         i = 0
         current = <optimized out>
         i = <optimized out>
         __func__ = {<optimized out> <repeats 16 times>}
         source = <optimized out>
         _g_boolean_var_ = <optimized out>
         was_in_call = <optimized out>
         user_data = <optimized out>
         callback = <optimized out>
         cb_funcs = <optimized out>
         cb_data = <optimized out>
         need_destroy = <optimized out>
         dispatch = <optimized out>
         prev_source = <optimized out>
         begin_time_nsec = <optimized out>
         _g_boolean_var_ = <optimized out>
#9 g_main_context_dispatch (context=0x562c6a0d7...

I manually retraced the crash file Dan provided and the results follow:

Stacktrace:
 #0  0x00007f3250972202 in g_strfreev (str_array=<optimized out>) at ../../../glib/gstrfuncs.c:2552
         i = 0
 #1  g_strfreev (str_array=0x69726f6972500a67) at ../../../glib/gstrfuncs.c:2546
         i = <optimized out>
 #2  0x0000562c680f57ff in hook_command_exists (cmd=<optimized out>) at hooks.c:137
         cargv = 0x562c6a3edc70
         result = 1
         unquoted = 0x562c6a3cfb50 "/bin/true"
         error = 0x0
         cargc = 1
         pathdirs = 0x69726f6972500a67
         result = <optimized out>
         unquoted = <optimized out>
         cargv = <optimized out>
         error = <optimized out>
         out = <optimized out>
         cargc = <optimized out>
         pathdirs = <optimized out>
         i = <optimized out>
         pathdir = <optimized out>
         fname = <optimized out>
 #3  is_hook_relevant (hook_file=hook_file@entry=0x562c6a4c0073 "bug") at hooks.c:717
         res = <optimized out>
         filename = 0x562c6a2277e0 "/var/lib/update-notifier/user.d/bug"
         f = <optimized out>
         rfc822 = 0x562c6a19d540
         b = <optimized out>
 #4  0x0000562c680f6b65 in check_update_hooks (ta=0x562c6a40e1b0) at hooks.c:781
         new_mtime = <optimized out>
         elm = <optimized out>
         hf = <optimized out>
         dir = 0x562c6a185660
         hook_file = 0x562c6a4c0073 "bug"
         priv = 0x562c6a238bc0
         unseen_count = 0
         __PRETTY_FUNCTION__ = "check_update_hooks"
 #5  0x0000562c680f7268 in hook_tray_icon_init (ta=<optimized out>) at hooks.c:969
         priv = <optimized out>
 #6  0x0000562c680f4933 in tray_icons_init (un=0x562c6a1ddd30, un@entry=<error reading variable: value has been optimized out>) at update-notifier.c:447
 No locals.
 #7  0x00007f3250956e38 in g_timeout_dispatch (source=0x562c6a195330, callback=<optimized out>, user_data=<optimized out>) at ../../../glib/gmain.c:4889
         timeout_source = 0x562c6a195330
         again = <optimized out>
 #8  0x00007f325095674f in g_main_dispatch (context=0x562c6a0d7060) at ../../../glib/gmain.c:3337
         dispatch = 0x7f3250956e20 <g_timeout_dispatch>
         prev_source = 0x0
         begin_time_nsec = 0
         was_in_call = 0
         user_data = 0x562c6a1ddd30
         callback = 0x562c680f4870 <tray_icons_init>
         cb_funcs = <optimized out>
         cb_data = 0x562c6a1bedc0
         need_destroy = <optimized out>
         source = 0x562c6a195330
         current = 0x562c6a1317c0
         i = 0
         current = <optimized out>
         i = <optimized out>
         __func__ = {<optimized out> <repeats 16 times>}
         source = <optimized out>
         _g_boolean_var_ = <optimized out>
         was_in_call = <optimized out>
         user_data = <optimized out>
         callback = <optimized out>
         cb_funcs = <optimized out>
         cb_data = <optimized out>
         need_destroy = <optimized out>
         dispatch = <optimized out>
         prev_source = <optimized out>
         begin_time_nsec = <optimized out>
         _g_boolean_var_ = <optimized out>
 #9  g_main_context_dispatch (context=0x562c6a0d7060) at ../../../glib/gmain.c:4055
 No locals.
 #10 0x00007f32509a9c68 in g_main_context_iterate.constprop.0 (context=0x562c6a0d7060, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:4131
         max_priority = 2147483647
         timeout = 845
         some_ready = 1
         nfds = <optimized out>
         allocated_nfds = <optimized out>
         fds = 0x562c6a1dc450
         begin_time_nsec = 0
 #11 0x00007f3250955db3 in g_main_loop_run (loop=0x562c6a1dc430) at ../../../glib/gmain.c:4329
         self = <optimized out>
         __func__ = "g_main_loop_run"
 #12 0x00007f325104a17d in gtk_main () at ../../../../gtk/gtkmain.c:1329
         loop = 0x562c6a1dc430
 #13 0x0000562c680f40f5 in main (argc=<optimized out>, argv=<optimized out>) at update-notifier.c:649
         un = 0x562c6a1ddd30
         error = 0x0
         pid_file = <optimized out>
         rc = 0
         lockfn = <optimized out>
         dirname = 0x7ffef986bf20 ""
StacktraceAddressSignature: /usr/bin/update-notifier:11:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6800.0+54202:/usr/bin/update-notifier+37ff:/usr/bin/update-notifier+4b65:/usr/bin/update-notifier+5268:/usr/bin/update-notifier+2933:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6800.0+38e38:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6800.0+3874f:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6800.0+8bc68:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6800.0+37db3:/usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2404.21+1c517d:/usr/bin/update-notifier+20f5
StacktraceSource:
 #0  0x00007f3250972202 in g_strfreev (str_array=<optimized out>) at ../../../glib/gstrfuncs.c:2552
   [Error: gstrfuncs.c was not found in source tree]
 #1  g_strfreev (str_array=0x69726f6972500a67) at ../../../glib/gstrfuncs.c:2546
   [Error: gstrfuncs.c was not found in source tree]
 #2  0x0000562c680f57ff in hook_command_exists (cmd=<optimized out>) at hooks.c:137
   132:    g_debug_hooks("failed to find command in PATH");
   133: 
   134: out:
   135:    if(error) g_error_free(error);
   136:    if(cargv) g_strfreev(cargv);
   137:    if(pathdirs) g_strfreev(pathdirs);
   138:    if(unquoted) g_free(unquoted);
   139:    return result;
   140: }
   141: 
   142: static gboolean
 #3  is_hook_relevant (hook_file=hook_file@entry=0x562c6a4c0073 "bug") at hooks.c:717
   712:    // check that the Command we are offering exists
   713:    if(res) {
   714:       b = rfc822_header_lookup(rfc822, "Command");
   715:       if(b != NULL) {
   716: 	 g_debug_hooks("found Command: '%s'", b);
   717: 	 res = hook_command_exists(b);
   718:       }
   719:    }
   720: 
   721:    g_free(filename);
   722:    rfc822_header_free_all(rfc822);
 #4  0x0000562c680f6b65 in check_update_hooks (ta=0x562c6a40e1b0) at hooks.c:781
   776:    int unseen_count = 0;
   777:    while((hook_file=g_dir_read_name(dir)) != NULL) {
   778:       g_debug_hooks("investigating file '%s'", hook_file); 
   779: 
   780:       // check if the hook still applies (for e.g. DontShowAfterReboot)
   781:       if(!is_hook_relevant(hook_file)) {
   782: 	 g_debug_hooks("not relevant: '%s'",hook_file);
   783: 	 continue;
   784:       }
   785:       // see if we already know about this hook filename
   786:       elm = g_list_find_custom(priv->hook_files,hook_file,
 #5  0x0000562c680f7268 in hook_tray_icon_init (ta=<optimized out>) at hooks.c:969
   964: 
   965:    /* read already seen hooks */
   966:    init_already_seen_hooks(ta);
   967:    
   968:    /* Check for hooks */
   969:    check_update_hooks(ta);
   970: }
 #6  0x0000562c680f4933 in tray_icons_init (un=0x562c6a1ddd30, un@entry=<error reading variable: value has been optimized out>) at update-notifier.c:447
   442:       un->update = NULL;
   443: 
   444:    /* update hook icon*/
   445:    un->hook = g_new0 (TrayApplet, 1);
   446:    trayapplet_create(un->hook, un, "hook-notifier");
   447:    hook_tray_icon_init(un->hook);
   448: 
   449:    /* crashreport detected icon */
   450:    un->crashreport = g_new0 (TrayApplet, 1);
   451:    trayapplet_create(un->crashreport, un, "apport");
   452:    crashreport_tray_icon_init(un->crashreport);
 #7  0x00007f3250956e38 in g_timeout_dispatch (source=0x562c6a195330, callback=<optimized out>, user_data=<optimized out>) at ../../../glib/gmain.c:4889
   [Error: gmain.c was not found in source tree]
 #8  0x00007f325095674f in g_main_dispatch (context=0x562c6a0d7060) at ../../../glib/gmain.c:3337
   [Error: gmain.c was not found in source tree]
 #9  g_main_context_dispatch (context=0x562c6a0d7060) at ../../../glib/gmain.c:4055
   [Error: gmain.c was not found in source tree]
 #10 0x00007f32509a9c68 in g_main_context_iterate.constprop.0 (context=0x562c6a0d7060, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:4131
   [Error: gmain.c was not found in source tree]
 #11 0x00007f3250955db3 in g_main_loop_run (loop=0x562c6a1dc430) at ../../../glib/gmain.c:4329
   [Error: gmain.c was not found in source tree]
 #12 0x00007f325104a17d in gtk_main () at ../../../../gtk/gtkmain.c:1329
   [Error: gtkmain.c was not found in source tree]
 #13 0x0000562c680f40f5 in main (argc=<optimized out>, argv=<optimized out>) at update-notifier.c:649
   644: 	monitor_init (un);
   645: 
   646: 	/* Start the main gtk loop */
   647: 	g_unix_signal_add_full (G_PRIORITY_DEFAULT, SIGINT, sigint_cb,
   648: 				NULL, NULL);
   649: 	gtk_main ();
   650: 
   651: 	return 0;
   652: }

Dan Bungert (dbungert) on 2021-04-29

description:

updated

Sebastien Bacher (seb128) on 2021-04-30

Changed in update-notifier (Ubuntu):
status:	Confirmed → Fix Committed
Changed in update-notifier (Ubuntu Hirsute):
assignee:	nobody → Dan Bungert (dbungert)
importance:	Undecided → High

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-04-30:

#9

tests.tgz Edit (1.2 KiB, application/x-tar)

Test hooks to cover the cases introduced by the original change.

Dan Bungert (dbungert) on 2021-04-30

description:

updated

Dan Bungert (dbungert) on 2021-04-30

description:

updated

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-04-30:

#10

hirsute-update-notifier-2-3.192.40.2.debdiff Edit (3.0 KiB, text/plain)

Requesting sponsorship for SRU of hirsute-update-notifier-2-3.192.40.2.debdiff

Changed in update-notifier (Ubuntu Hirsute):
status:	New → Confirmed
tags:	added: patch
Changed in update-notifier (Ubuntu Hirsute):
assignee:	Dan Bungert (dbungert) → nobody

Mathew Hodson (mhodson) on 2021-05-02

tags:

added: regression-release

Revision history for this message

Steve Langasek (vorlon) wrote on 2021-05-03: Please test proposed package

#11

Hello Sebastien, or anyone else affected,

Accepted update-notifier into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.40.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-notifier (Ubuntu Hirsute):
status:	Confirmed → Fix Committed
tags:	added: verification-needed verification-needed-hirsute

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2021-05-03: Autopkgtest regression report (update-notifier/3.192.40.2)

#12

All autopkgtests for the newly accepted update-notifier (3.192.40.2) for hirsute have finished running.
The following regressions have been reported in tests triggered by the package:

update-motd/3.7 (ppc64el, arm64, s390x, armhf, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/hirsute/update_excuses.html#update-notifier

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-05-03:

#13

I believe update-notifier is the innocent bystander here, and the failure is caused by https://bugs.launchpad.net/ubuntu/+source/update-motd/+bug/1926660

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-05-04:

#14

The same scenario occurs on impish, without update-notifier being involved:
https://autopkgtest.ubuntu.com/packages/u/update-motd/impish/amd64

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-05-07:

#15

This bug was fixed in the package update-notifier - 3.192.42

---------------
update-notifier (3.192.42) impish; urgency=medium

  [ Dan Bungert ]
  * Address segfault regression in the 3.192.40 update (LP: #1926298) related
    to hook command path lookup

-- Brian Murray <email address hidden> Thu, 29 Apr 2021 15:07:27 -0700

Changed in update-notifier (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-05-20:

#16

Self-verified as follows:

* use virtual machine manager to create a KVM with
  /srv/iso/hirsute/ubuntu-21.04-desktop-amd64.iso, 4 cpu/8G mem
* Running installer, choosing default options in the install wizard except to
  correct timezone to MDT. "ubuntu" user created.
* Install proceeds until reboot prompt, and I choose reboot.
* Next->Next->Next thru "welcome to ubuntu"
* Software updater offers updates, choose "Install now", which causes the
  update-notifier version to go to 3.192.40.1
* Acquire tests.tgz from bug
* kill update-notifier process
* copy all hooks from tests.tgz to /var/lib/update-notifier/user.d
* log out / log in / wait
* observe crash dialog (as expected)
* remove crash entry from /var/crash. We don't want to confuse the expected
  crash from ver 3.192.40 / 3.192.40.1 with a crash on 3.192.40.2
* if ~/.config/update-notifier/hooks_seen is present we would want to remove
  it, but it isn't present for me
* add hirsute-proposed to sources.list
* instll update-notifier 3.192.40.2 via 'sudo apt install update-notifier' * remove hirsute-proposed from sources.list * log out / log in / wait * expect to see 10 notifications from update-notifier and no crash

Self-verified as follows:

* use virtual machine manager to create a KVM with                                                                                   
  /srv/iso/hirsute/ubuntu-21.04-desktop-amd64.iso, 4 cpu/8G mem                                                                      
* Running installer, choosing default options in the install wizard except to                                                        
  correct timezone to MDT.  "ubuntu" user created.                                                                                   
* Install proceeds until reboot prompt, and I choose reboot.                                                                         
* Next->Next->Next thru "welcome to ubuntu"                                                                                          
* Software updater offers updates, choose "Install now", which causes the                                                            
  update-notifier version to go to 3.192.40.1                                                                                        
* Acquire tests.tgz from bug                                                                                                         
* kill update-notifier process                                                                                                       
* copy all hooks from tests.tgz to /var/lib/update-notifier/user.d                                                                   
* log out / log in / wait                                                                                                            
* observe crash dialog (as expected)                                                                                                              
* remove crash entry from /var/crash.  We don't want to confuse the expected                                                         
  crash from ver 3.192.40 / 3.192.40.1 with a crash on 3.192.40.2                                                                    
* if ~/.config/update-notifier/hooks_seen is present we would want to remove                                                         
  it, but it isn't present for me                                                                                                    
* add hirsute-proposed to sources.list                                                                                               
* instll update-notifier 3.192.40.2 via 'sudo apt install update-notifier'                                                           * remove hirsute-proposed from sources.list                                                                                          * log out / log in / wait                                                                                                            * expect to see 10 notifications from update-notifier and no crash

tags:

added: verification-done-hirsute
removed: verification-needed-hirsute

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-05-21:

#17

Also 3.192.42, which has the impish version of this fix, is not showing crashes for this problem:
https://errors.ubuntu.com/problem/74e558a18105a756eb6a4b6aaa7145b79471754a

Revision history for this message

Dan Bungert (dbungert) wrote on 2021-05-21:

#18

Same for 3.192.40.2 in hirsute-proposed.

Mathew Hodson (mhodson) on 2021-05-22

tags:

removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-05-24:

#19

This bug was fixed in the package update-notifier - 3.192.40.2

---------------
update-notifier (3.192.40.2) hirsute; urgency=medium

  [ Dan Bungert ]
  * Address segfault regression in the 3.192.40 update (LP: #1926298) related
    to hook command path lookup

-- Brian Murray <email address hidden> Thu, 29 Apr 2021 14:45:05 -0700

Changed in update-notifier (Ubuntu Hirsute):
status:	Fix Committed → Fix Released

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2021-05-24: Update Released

#20

The verification of the Stable Release Update for update-notifier has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Ubuntu
update-notifier package

Segfault added in the recent changes

Bug Description

Related branches

Duplicates of this bug

Other bug subscribers

Patches

Bug attachments

Remote bug watches

Affects		Status	Importance	Assigned to	Milestone
	update-notifier (Ubuntu)	Fix Released	High	Dan Bungert
	Hirsute	Fix Released	High	Unassigned

Ubuntuupdate-notifier package

Segfault added in the recent changes

Bug Description

Related branches

Duplicates of this bug

Other bug subscribers

Patches

Bug attachments

Remote bug watches

Ubuntu
update-notifier package