kolla

horizon: monitoring_policy.json placed incorrectly

Bug #1928408 reported by Scott Shambarger on 2021-05-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	kolla	Fix Released	Medium	Scott Shambarger

Bug Description

The extended_start.sh script for horizon container copies the monitoring_policy.json file to the wrong directory, so it's not found by horizon.

Current: "${SITE_PACKAGES}/openstack_dashboard/conf/monitoring_policy.json"

Correct: "/etc/openstack-dashboard/monitoring_policy.json"

The result is that the Monitoring menu is always displayed, and not based on policy.

There's a related problem with the actual policy file, as it currently does not allow admin access; this seems counter to the documentation that the admin role should have access to everything... so fixing this actually makes the Monitoring menu unavailable to admin unless added role:monasca-user

If necessary, I can log a bug with monasca-ui as well...?

Tags:

Revision history for this message

Mark Goddard (mgoddard) wrote on 2021-05-17:

Hi Scott. I think config_monasca_ui in docker/horizon/extend_start.sh is the place for a fix.

Changed in kolla:
status:	New → Triaged
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-05-24: Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla/+/792838

Changed in kolla:
status:	Triaged → In Progress

Scott Shambarger (sshambar) on 2021-05-24

Changed in kolla:
assignee:	nobody → Scott Shambarger (sshambar)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-17: Fix merged to kolla (master)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/792838
Committed: https://opendev.org/openstack/kolla/commit/f68dfb88fdbad51322727575457b3d78a70466b1
Submitter: "Zuul (22348)"
Branch: master

commit f68dfb88fdbad51322727575457b3d78a70466b1
Author: Scott Shambarger <email address hidden>
Date: Mon May 24 10:51:23 2021 -0700

horizon: Correct location of monitoring_policy file

Patch to correctly copy monitoring_policy.json into
/etc/openstack-dashboard. Policy was misplaced, and not being enforced.

Note that by current default policy, admin doesn't not have Monitoring
access.

Closes-Bug: #1928408
Change-Id: I4faabdfa9c273fc61b536e6ce88b8d71ab2fc581

Changed in kolla:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-21: Fix proposed to kolla (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla/+/797263

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-21: Fix proposed to kolla (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla/+/797300

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-21: Fix proposed to kolla (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/kolla/+/797301

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-21: Fix merged to kolla (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/797263
Committed: https://opendev.org/openstack/kolla/commit/d578ac26063db885b022e3d4ef52b432831c6f26
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit d578ac26063db885b022e3d4ef52b432831c6f26
Author: Scott Shambarger <email address hidden>
Date: Mon May 24 10:51:23 2021 -0700

horizon: Correct location of monitoring_policy file

Patch to correctly copy monitoring_policy.json into
/etc/openstack-dashboard. Policy was misplaced, and not being enforced.

Note that by current default policy, admin doesn't not have Monitoring
access.

    Closes-Bug: #1928408
    Change-Id: I4faabdfa9c273fc61b536e6ce88b8d71ab2fc581
    (cherry picked from commit f68dfb88fdbad51322727575457b3d78a70466b1)

tags:

added: in-stable-wallaby

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-22: Fix merged to kolla (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/797300
Committed: https://opendev.org/openstack/kolla/commit/32eb32f1b66416a2ccd385bd4afee765bf1eb712
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 32eb32f1b66416a2ccd385bd4afee765bf1eb712
Author: Scott Shambarger <email address hidden>
Date: Mon May 24 10:51:23 2021 -0700

horizon: Correct location of monitoring_policy file

Patch to correctly copy monitoring_policy.json into
/etc/openstack-dashboard. Policy was misplaced, and not being enforced.

Note that by current default policy, admin doesn't not have Monitoring
access.

    Closes-Bug: #1928408
    Change-Id: I4faabdfa9c273fc61b536e6ce88b8d71ab2fc581
    (cherry picked from commit f68dfb88fdbad51322727575457b3d78a70466b1)

tags:

added: in-stable-victoria

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-22: Fix included in openstack/kolla 12.0.0.0rc2

This issue was fixed in the openstack/kolla 12.0.0.0rc2 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-06-22: Fix merged to kolla (stable/ussuri)

#10

Reviewed: https://review.opendev.org/c/openstack/kolla/+/797301
Committed: https://opendev.org/openstack/kolla/commit/f7556324fd3850d3e63320fdd2d4086055fc9c87
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit f7556324fd3850d3e63320fdd2d4086055fc9c87
Author: Scott Shambarger <email address hidden>
Date: Mon May 24 10:51:23 2021 -0700

horizon: Correct location of monitoring_policy file

Patch to correctly copy monitoring_policy.json into
/etc/openstack-dashboard. Policy was misplaced, and not being enforced.

Note that by current default policy, admin doesn't not have Monitoring
access.

    Closes-Bug: #1928408
    Change-Id: I4faabdfa9c273fc61b536e6ce88b8d71ab2fc581
    (cherry picked from commit f68dfb88fdbad51322727575457b3d78a70466b1)