[TGL] enable USB-dw3

Bug #1929892 reported by Chao Qin
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
intel
Invalid
Undecided
Brad Figg
linux (Ubuntu)
Expired
Undecided
Unassigned
linux-intel (Ubuntu)
Invalid
High
Brad Figg

Bug Description

Description
Enable USB-dw3 for Tiger Lake

Hardware: Tiger Lake

Target Release: 21.04
Target Kernel: TBD

External links:
https://github.com/intel/linux-intel-quilt/tree/mainline-tracking-v5.11-yocto-210223T083754Z

Revision history for this message
Chao Qin (chaoqin) wrote :

Please find the following patches in the above external link

0002-usb-dwc3-pci-ID-for-Tiger-Lake-CPU.usb-typec

Chao Qin (chaoqin)
no longer affects: ubuntu
tags: added: lookout-canyon
Revision history for this message
Chao Qin (chaoqin) wrote :

This patch is already upstreamed in mainline kernel v5.13

73203bde3a95a48f27b2454dc6b955280c641afe

Changed in linux-intel (Ubuntu):
assignee: nobody → Hsuan-Yu Lin (shanelin)
importance: Undecided → High
Hsuan-Yu Lin (shanelin)
Changed in linux-intel (Ubuntu):
status: New → In Progress
Revision history for this message
Hsuan-Yu Lin (shanelin) wrote :

Patches are ready and under review.

Jesse Sung (wenchien)
information type: Private → Public
Jesse Sung (wenchien)
Changed in linux-intel (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Stefan Bader (smb) wrote :

This is getting reverted because it breaks the kernel build:

drivers/usb/dwc3/dwc3-pci.c:379:22: error: "dwc3_pci_intel_swnode" undeclared here (not in a function)
  379: (kernel_ulong_t) &dwc3_pci_intel_swnode, },

Changed in linux-intel (Ubuntu):
status: Fix Committed → Triaged
Hsuan-Yu Lin (shanelin)
Changed in linux-intel (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Hsuan-Yu Lin (shanelin) wrote :

This patch 73203bde3a95a48f27b2454dc6b955280c641afe needs another 2 dependency patches (Please see bug 1929902 comment #3)

I will re-submit the new patch set.

---
Reference:
e492ce9bcaa1 usb: dwc3: pci: Register a software node for the dwc3 platform device
e68d0119e328 software node: Introduce device_add_software_node()

Revision history for this message
Hsuan-Yu Lin (shanelin) wrote :

Patches are ready and under review.

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Hsuan-Yu Lin (shanelin) wrote :

Hi @chaoqin,

The patch "0002-usb-dwc3-pci-ID-for-Tiger-Lake-CPU.usb-typec" has been backported to 5.11.0-1012.14 on proposed. [1]

Could you provide how to verify it?
Thanks!

---
[1] https://launchpad.net/ubuntu/+source/linux-intel/5.11.0-1012.14

Revision history for this message
Anthony Wong (anthonywong) wrote :
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Tried latest desktop image[1]. USB-dw3 is enabled.
Here is the log:

u@tgl:~$ dmesg | grep 3fe
[ 21.103681] pci 0000:00:0d.1: [8086:9a15] type 00 class 0x0c03fe
[ 21.199707] pci 0000:00:14.1: [8086:43ee] type 00 class 0x0c03fe

u@tgl:~$ sudo modprobe dwc3_pci
u@tgl:~$ lspci -v
...
00:0d.1 USB controller: Intel Corporation Device 9a15 (rev 04) (prog-if fe [USB Device])
 Subsystem: Intel Corporation Device 7270
 Flags: bus master, fast devsel, latency 0, IRQ 16
 Memory at 607d200000 (64-bit, non-prefetchable) [size=2M]
 Memory at 607d4f1000 (64-bit, non-prefetchable) [size=4K]
 Capabilities: [80] Power Management version 3
 Capabilities: [90] Vendor Specific Information: Len=14 <?>
 Kernel driver in use: dwc3-pci
 Kernel modules: dwc3_pci
...
00:14.1 USB controller: Intel Corporation Device 43ee (prog-if fe [USB Device])
 Subsystem: Intel Corporation Device 7270
 Flags: fast devsel, IRQ 17
 Memory at 607d000000 (64-bit, non-prefetchable) [size=2M]
 Memory at 607d4ed000 (64-bit, non-prefetchable) [size=4K]
 Capabilities: [80] Power Management version 3
 Capabilities: [90] Vendor Specific Information: Len=14 <?>
 Kernel modules: dwc3_pci

u@tgl:~$ dpkg -l | grep linux-image
ii linux-image-5.11.0-1012-intel 5.11.0-1012.14 amd64 Signed kernel image generic
ii linux-image-intel 5.11.0.1012.15 amd64 Generic Linux kernel image

---
[1] https://private-fileshare.canonical.com/~brian/iotg-focal-desktop-20210813.img

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1929892

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
tags: added: hirsute
Revision history for this message
Brad Figg (brad-figg) wrote :

We get this for free with the move to a 5.13 based focal:linux-intel kernel.

Changed in intel:
status: New → Invalid
Changed in linux-intel (Ubuntu):
status: In Progress → Invalid
Changed in intel:
assignee: nobody → Brad Figg (brad-figg)
Changed in linux-intel (Ubuntu):
assignee: Hsuan-Yu Lin (shanelin) → Brad Figg (brad-figg)
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for linux (Ubuntu) because there has been no activity for 60 days.]

Changed in linux (Ubuntu):
status: Incomplete → Expired
Revision history for this message
Brian Murray (brian-murray) wrote : [linux-intel/focal] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for focal for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.