Evergreen

MARC_NAMESPACE in AppUtils should be constant

Bug #1930747 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
Evergreen 3.9-beta
3.7
Fix Released
Undecided
Unassigned
Evergreen 3.7.3
3.8
Fix Released
Undecided
Unassigned
Evergreen 3.8.1

Bug Description

The "my" variable $MARC_NAMESPACE added to OpenILS::Application::AppUtils as part of the work for bug 1881607, should be a constant and not a variable. Making it a constant protects it from accidental change and better conveys the intent of how it is to be used.

There's also an argument to be made for moving it to Const.pm where it could be exported to other modules.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Here's a branch that makes MARC_NAMESPACE constant without moving it to Const.pm:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1930747-constant-MARC_NAMESPACE

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.8-beta
Revision history for this message
Jason Boyer (jboyer) wrote :

Since we have 3 separate definitions for MARC_NAMESPACE, here's a branch that moves it into Const.pm: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1930747_constantly_named / working/user/jboyer/lp1930747_constantly_named

Terran McCanna (tmccanna)
tags: added: cleanup
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.8-beta → none
Michele Morgan (mmorgan)
no longer affects: evergreen/3.6
Changed in evergreen:
milestone: none → 3.8.1
Jason Stephenson (jstephenson)
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Works for me. Tests still pass, except for one test that is broken for other reasons.

Pushed to rel_3_7, rel_3_8, and master.

Thanks, Jason Boyer!

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
status: New → Fix Committed
milestone: 3.8.1 → none
milestone: none → 3.9-beta
Terran McCanna (tmccanna)
tags: added: signedoff
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.