Angular: place hold fails with a generic error when Notify by SMS is selected without a carrier

Bug #1933381 reported by Dan Briem
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.6
Fix Released
Low
Unassigned

Bug Description

When placing a hold in the Angular catalog (tested on 3.6.3), if Notify by SMS is selected, but a SMS carrier isn't, the hold fails with the generic error DATABASE_UPDATE_FAILED.

It might not be obvious to the staff member why it failed.

When placing a hold in the OPAC the mobile number and carrier are required if the notification method is SMS. This might be helpful in the Angular catalog as well.

Dan Briem (dbriem)
tags: added: staffcatalog
Revision history for this message
Christine Burns (christine-burns) wrote :

tested on 3.7 issue confirmed

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Dan Briem (dbriem) wrote :

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1933381_notify_sms_required_fields

If notify by SMS is selected, the SMS number and carrier are required, marked red if empty, and the Place Hold(s) button is disabled until they are set.

tags: added: pullrequest
Erica Rohlfs (erohlfs)
Changed in evergreen:
assignee: nobody → Erica Rohlfs (erohlfs)
Erica Rohlfs (erohlfs)
Changed in evergreen:
assignee: Erica Rohlfs (erohlfs) → nobody
Erica Rohlfs (erohlfs)
Changed in evergreen:
assignee: nobody → Erica Rohlfs (erohlfs)
Revision history for this message
Erica Rohlfs (erohlfs) wrote :

I have tested this code and consent to signing off on it with my name, Erica Rohlfs and my email address, <email address hidden>.

Changed in evergreen:
assignee: Erica Rohlfs (erohlfs) → nobody
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_6. Thanks, Dan and Erica!

Changed in evergreen:
milestone: none → 3.7.2
importance: Undecided → Low
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.