Incorrect update-alternatives usage on CentOS

Bug #1936947 reported by Pierre Riteau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Medium
Michal Nasiadka
Ussuri
New
Undecided
Unassigned
Victoria
Fix Released
Undecided
Unassigned
Wallaby
Fix Released
Undecided
Unassigned
Xena
Fix Released
Undecided
Unassigned
Yoga
Fix Released
Medium
Michal Nasiadka

Bug Description

Follow up to https://bugs.launchpad.net/kolla/+bug/1884778

The following can be seen in neutron_server logs when using centos images (at least on Victoria):

++ export UPDATE_ALTERNATIVES=/usr/sbin/update-alternatives
++ UPDATE_ALTERNATIVES=/usr/sbin/update-alternatives
++ /usr/sbin/update-alternatives --query iptables
alternatives version 1.13 - Copyright (C) 2001 Red Hat, Inc.
This may be freely redistributed under the terms of the GNU Public License.

usage: alternatives --install <link> <name> <path> <priority>
                    [--initscript <service>]
                    [--family <family>]
                    [--slave <slave_link> <slave_name> <slave_path>]*
       alternatives --remove <name> <path>
       alternatives --auto <name>
       alternatives --config <name>
++ . /usr/local/bin/kolla_neutron_extend_start
       alternatives --display <name>
       alternatives --set <name> <path>
       alternatives --list
       alternatives --remove-all <name>
       alternatives --add-slave <name> <path> <slave_link> <slave_name> <slave_path>
       alternatives --remove-slave <name> <path> <slave_name>

common options: --verbose --test --help --usage --version --keep-missing
                --altdir <directory> --admindir <directory>
+++ [[ -n '' ]]
+++ [[ -n '' ]]

Revision history for this message
Michal Nasiadka (mnasiadka) wrote :

Seems update-alternatives on CentOS is too old (1.13) to support --query (needs at least 1.15)

Changed in kolla:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla/+/815781

Changed in kolla:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/815781
Committed: https://opendev.org/openstack/kolla/commit/2d1bbe72579f9209e151133352d4d6761f764f33
Submitter: "Zuul (22348)"
Branch: master

commit 2d1bbe72579f9209e151133352d4d6761f764f33
Author: Michal Nasiadka <email address hidden>
Date: Thu Oct 28 09:17:17 2021 +0200

    neutron: Use update-alternatives --display instead of --query

    --query is not supported before update-alternatives 1.15
    and CentOS uses 1.13

    Closes-Bug: #1936947
    Change-Id: I78da7eb2b6b5eae2b04fd95b24615bd4a572a1d6

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 14.0.0.0rc1

This issue was fixed in the openstack/kolla 14.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla/+/849816

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla/+/849817

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/kolla/+/849818

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/849818
Committed: https://opendev.org/openstack/kolla/commit/22ce46488b4cef8b35f328948a80ba9ba6fad8d9
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 22ce46488b4cef8b35f328948a80ba9ba6fad8d9
Author: Michal Nasiadka <email address hidden>
Date: Thu Oct 28 09:17:17 2021 +0200

    neutron: Use update-alternatives --display instead of --query

    --query is not supported before update-alternatives 1.15
    and CentOS uses 1.13

    Closes-Bug: #1936947
    Change-Id: I78da7eb2b6b5eae2b04fd95b24615bd4a572a1d6
    (cherry picked from commit 2d1bbe72579f9209e151133352d4d6761f764f33)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/849816
Committed: https://opendev.org/openstack/kolla/commit/62d7ef9e86f146c99f4fdea6d19827a6375b12e4
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 62d7ef9e86f146c99f4fdea6d19827a6375b12e4
Author: Michal Nasiadka <email address hidden>
Date: Thu Oct 28 09:17:17 2021 +0200

    neutron: Use update-alternatives --display instead of --query

    --query is not supported before update-alternatives 1.15
    and CentOS uses 1.13

    Closes-Bug: #1936947
    Change-Id: I78da7eb2b6b5eae2b04fd95b24615bd4a572a1d6
    (cherry picked from commit 2d1bbe72579f9209e151133352d4d6761f764f33)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/849817
Committed: https://opendev.org/openstack/kolla/commit/1cc710d00b2c9bcbbb8d444caa2f8cc360b76bae
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1cc710d00b2c9bcbbb8d444caa2f8cc360b76bae
Author: Michal Nasiadka <email address hidden>
Date: Thu Oct 28 09:17:17 2021 +0200

    neutron: Use update-alternatives --display instead of --query

    --query is not supported before update-alternatives 1.15
    and CentOS uses 1.13

    Closes-Bug: #1936947
    Change-Id: I78da7eb2b6b5eae2b04fd95b24615bd4a572a1d6
    (cherry picked from commit 2d1bbe72579f9209e151133352d4d6761f764f33)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 12.4.0

This issue was fixed in the openstack/kolla 12.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 13.3.0

This issue was fixed in the openstack/kolla 13.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla victoria-eol

This issue was fixed in the openstack/kolla victoria-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.