Placing holds as staff in traditional catalog in 3.7 doesn't always load user settings

Clarification: the holds group interface only appears if hold groups exist in the system. So, this is only an issue for systems where no hold groups have been created.

This bug affects users of the SPARK consortium, because we can only search the OPAC search groups via the Search Catalog-traditional option.

I asked Dale Rigney from Equinox for some comments on his research on this for PaILS:

I did test a workaround. This appears to be an issue with the HOLD GROUPS. If the staff member creates a Hold Group by going to Circulation -> Hold Groups and creates one via the New Hold Group button. After a Hold Group is created The Place Hold screen will load correctly and you will see a Place hold for patron Hold Group option, which is where the screen was getting an error.

This work around only works for title holds. Copy or Volume holds from the "traditional" search screen will still not work.

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=cb603058248bee41ae2d27e721cc50ce441d53d5

When no hold groups exist, its interface isn't present. When placing volume holds, the advanced link isn't present. Accessing attributes on those missing elements cause errors that prevent the patron info from loading.

This checks that those elements exist before accessing their attributes and adds a missing name attribute to the Bootstrap catalog to display the email address.

I've tested this patch by placing holds as a staff member in the traditional catalog and confirmed that the patron's user settings load when their barcode is entered.

- Tested both the TPAC and Bootstrap OPAC as the "traditional" catalog
- Tested title hold, call number hold, item hold
- Tested various combinations of patron user settings

In all cases the patron's preferences loaded when expected. Additionally, we have had this patch on our production system for almost two months after upgrading to 3.7.2.

I will open a separate bug for a remaining issue with the traditional catalog since 3.7 where clicking Submit on the place hold screen after retrieving a patron using Barcode Completion results in an internal server error.

Signoff branch on the way.

Promised signoff branch is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1939426_place_holds_user_settings_signoff

user/mmorgan/lp1939426_place_holds_user_settings_signoff

Thanks, Dan, Michele, and all! Branch merged to 3.7, 3.8, and master.

Just adding a link to the ISE bug mentioned in comment #5: bug 1965317