Vandelay Recent Imports Fetches Sessions in Parallel

Bug #1945003 reported by Bill Erickson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.11
Fix Released
Medium
Unassigned

Bug Description

Evergreen 3.6 and up.

Cataloging => MARC Batch Import/Export => Recent Imports

This UI retrieves Queue data related to each session tracker as a series of parallel requests. This can lead to excessive pcrud calls for large lists of sessions. Patch en route to serialize the requests.

Revision history for this message
Bill Erickson (berick) wrote :

Here's a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1945003-vand-tracker-serialize

To test, do about 20 Vandelay imports (if you don't already have a bunch of session data). Load the Recent Imports interface and confirm many sessions are displayed, but the number of pcrud processes remains well lower than the number of sessions.

On my test VM with 20 recent imports, my open-ils.pcrud drone count never exceeds 7 (which is 1 over min-child + min-idle).

Changed in evergreen:
milestone: none → 3.7.2
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Elaine Hardy (ehardy)
tags: added: cat-importexport
removed: vandelay
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
no longer affects: evergreen/3.6
Changed in evergreen:
milestone: 3.7.3 → none
Revision history for this message
Galen Charlton (gmc) wrote :

Signed off: user/gmcharlt/lp1945003_signoff

Note that the signoff branch includes a couple commits to work around the fact that the recent linter changes caused merge errors. Those two commits need not be cherry-picked when backporting to rel_3_11.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
tags: added: signedoff
Changed in evergreen:
milestone: none → 3.12.1
Revision history for this message
Galen Charlton (gmc) wrote :

Merged down to rel_3_11. Thanks, Bill!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.