Change drop-down menu 'on click' colour for better accessibility

Bug #1947520 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Evonne Cheung

Bug Description

When you are on a page that you own and click the 'More options' button, you see the option to delete the page. Clicking on that option turns the background into the primary colour, which makes the red trashbin icon usually invisible. The same is true for the 'More options' button on a page or collection on the 'Pages and collections' overview page.

Evonne will turn the 'on click' background into a grey one, not using the theme colour.

This will need to be checked in every theme, including the configurable one. There, a grey background is already used, but just to double check that it behaves correctly.

Another drop-down menu to check is the collection navigation.

To replicate:

1. Create an institution and add the site admin as member.
2. Create a collection with three pages.
3. Check the 'More options' button on a page, on 'Pages and collections', and the collection navigation with an 'on-click' action for a destructive action like 'Delete' for the 'More options' buttons, and a simple click onto the next page in the collection navigation drop-down menu to make sure that the text can be read.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12150

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12150
Committed: https://git.mahara.org/mahara/mahara/commit/574375f287ccbce239dfabe3b47ec9fd642f0b7a
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 574375f287ccbce239dfabe3b47ec9fd642f0b7a
Author: Evonne <email address hidden>
Date: Mon Oct 18 10:33:46 2021 +1300

Bug 1947520 Change drop-down menu 'on click' colour

Changed variable in raw, subsequently removed overrides in primary
and modern and custom.

behatnotneeded

Change-Id: I26c24a9c3dff9f80c0b7d585b61a5d5832ad58e4

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12161

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12161
Committed: https://git.mahara.org/mahara/mahara/commit/da24dc8be61cb850dee1143fb9d0b0005f0bccaa
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit da24dc8be61cb850dee1143fb9d0b0005f0bccaa
Author: Evonne <email address hidden>
Date: Mon Oct 18 10:33:46 2021 +1300

Bug 1947520 Change drop-down menu 'on click' colour

Changed variable in raw, subsequently removed overrides in primary
and modern and custom.

behatnotneeded

Change-Id: I26c24a9c3dff9f80c0b7d585b61a5d5832ad58e4
(cherry picked from commit 574375f287ccbce239dfabe3b47ec9fd642f0b7a)

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
milestone: 21.10rc2 → 21.10.0
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.