Portfolio completion page has link underline for sign-off and verification

Bug #1947634 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Evonne Cheung

Bug Description

When you have the sign-off block on a page and display the information on the 'Portfolio completion' page, the red dots for both 'Sign-off' and 'Verification' have link underlines when that shouldn't be the case.

To replicate:

1. Switch 'Portfolio completion' to 'Yes' for 'No institution'.
2. Create a personal portfolio page with the sign-off block and allow 'Verification' in it.
3. Share the page with another person and make them manager.
4. View the portfolio completion page as portfolio author.

Expected result: The red dot in the 'Sign-off' column doesn't have a link underline.
Actual result: There is an underline.

5. Sign off the page.
6. Log in as the other person and view the portfolio completion page.

Expected result: The red dot in the 'Verification' column doesn't have a link underline.
Actual result: There is an underline.

Tags: front-end
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12162

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12162
Committed: https://git.mahara.org/mahara/mahara/commit/ae55500066f49e4d9631a74c8a2e5f533253e1d9
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit ae55500066f49e4d9631a74c8a2e5f533253e1d9
Author: Evonne <email address hidden>
Date: Tue Oct 19 12:30:18 2021 +1300

Bug 1947634 Portfolio completion page sign-off and verification style

Removing underline for sign-off, unsign-off, and verified icons.

behatnotneeded

Change-Id: I2a14ea57d66c88eda27dca1604c2048537c6ee5e

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12166

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12166
Committed: https://git.mahara.org/mahara/mahara/commit/898c309fde3d2dbf04de44c573145c420d8e2d6e
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 898c309fde3d2dbf04de44c573145c420d8e2d6e
Author: Evonne <email address hidden>
Date: Tue Oct 19 12:30:18 2021 +1300

Bug 1947634 Portfolio completion page sign-off and verification style

Removing underline for sign-off, unsign-off, and verified icons.

behatnotneeded

Change-Id: I2a14ea57d66c88eda27dca1604c2048537c6ee5e
(cherry picked from commit ae55500066f49e4d9631a74c8a2e5f533253e1d9)

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
milestone: 21.10rc2 → 21.10.0
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.