SmartEvidence editor accessibility bug fixes for button alignment and heading levels

Bug #1949914 reported by Dianne Tennent
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

Related to this bug: https://bugs.launchpad.net/mahara/+bug/1824056
And this patch: https://reviews.mahara.org/#/c/12215/2

Things I noticed while improving accessibility on this SmartEvidence editor (json-editor):

1. Alignment between the 'collapse' and 'add' buttons in the 'Standards' and 'Standard elements' headings is slightly off. See attached screenshot.

2. All of the headings in the editor are h3 tags that wrap around a few divs and buttons. This is semantically incorrect and I suspect is what is preventing the screen reader from reading the h3 heading text.

Revision history for this message
Dianne Tennent (dianne-t) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12229

Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 22.04.0
tags: added: accessibility
summary: - SmartEvidence editor minor bug fixes
+ SmartEvidence editor accessibility bug fixes for button alignment and
+ heading levels
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12229
Committed: https://git.mahara.org/mahara/mahara/commit/912275460d194cf3f134cbe1c9a4dd223b3cad24
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 912275460d194cf3f134cbe1c9a4dd223b3cad24
Author: Dianne Tennent <email address hidden>
Date: Fri Nov 5 15:40:07 2021 +1300

Bug 1949914: adjust mark-up in json editor

Adjustments to mark-up from jsoneditor
library to be accessible and semantically
correct.

Change-Id: Ia8ca50b6e32760f6b543a371b2ac7e8a17f7a571

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.