Issues with 'Current submissions' and 'Archived submissions'

Bug #1952540 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Dianne Tennent
21.10
Fix Released
Medium
Unassigned
22.04
Fix Released
Medium
Dianne Tennent

Bug Description

There are a couple of issues with the submission reporting screens in Admin menu -> Groups -> Current / Archived submissions

1. On the tab 'Current submissions', the column header 'Submitted on' can be clicked but the table is not actually sorted according to the date.

To replicate:

1. Submit a few portfolios at different times or manipulate the database to get different dates.
2. Sort the column 'Submitted on'.

Results:
- Expected: The results are sorted in ascending or descending order.
- Actual: Nothing happens.

2. On the tab 'Current submissions', the CSV file contains the column 'archivectime' but that is empty because the submission hasn't been archived yet. Instead, it should display the submitted time in a human-readable time format like we use in the 'Account details' report for example so that the column can be sorted in the CSV file.

3. On the tab 'Current submissions', the CSV file should not contain the columns 'filetitle', 'filepath', and 'filename' because they are irrelevant for this report.

4. On the tab 'Archived submissions', the CSV file contains the column 'archivectime' that contains data. It is the Unix timestamp though that is hard to read. Instead, it should display the timestamp in a human-readable yet also sortable fashion like in the 'Account details' report for the 'login date' when exported as CSV.

5. On the tab 'Archived submissions', the 'ID' help text has been mislabeled. It should read 'The ID of the archive file on the server. That allows you to match it to the file mentioned in the CSV download.' However, right now, it takes the help text for the ID field on the 'Current submissions' screen.

6. On both tabs when logged in as institution admin, the usernames are not linked to their /admin/users/edit.php?id= page. This is the case for site admins though.

Combining the two menu items into one is taken care of in bug #1949421.

description: updated
description: updated
description: updated
description: updated
Revision history for this message
Dianne Tennent (dianne-t) wrote :

1. On Current submissions, when I click 'Submitted on' to sort by submission date, and then click the Archived Submissions tab, I get a large error message.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12284

Revision history for this message
Dianne Tennent (dianne-t) wrote :

Notes from Robert:
ok looking at htdocs/theme/raw/templates/admin/users/searchusernamecolumn.tpl if the viewer of the page is an institution admin but they are not an institutional admin of the person who submitted the archive they don't get the link with the username
so I'm guessing something like the following scenario - institution admin is in institution one and in group A - submitter is in group A as well but is in institution two

I have noticed a problem on the current submissions tab - if an institution admin submits a page to a group where they are only a group member they can see the submission listed with a checkbox to allow for release but nothing happens when they try to release it.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12284
Committed: https://git.mahara.org/mahara/mahara/commit/6ba8f394b58916afd4e766774f5f9be3ab10a23a
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 6ba8f394b58916afd4e766774f5f9be3ab10a23a
Author: Dianne Tennent <email address hidden>
Date: Fri Dec 3 11:32:03 2021 +1300

Bug 1952540: Current and Archived submissions

- allow sort by submitted time
- update current submissions csv file column names
- add correct help text to archived id column
- different csv filename for archived and current
- format timestamps

Change-Id: I6aaf3ce250d976e91e5fcea11e8d11c2758168fc

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12305

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12306

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12306
Committed: https://git.mahara.org/mahara/mahara/commit/a5b703d23259d0fea11bebdaf3e16e2d274798e7
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit a5b703d23259d0fea11bebdaf3e16e2d274798e7
Author: Robert Lyon <email address hidden>
Date: Fri Dec 17 08:33:41 2021 +1300

Bug 1952540: Current and Archived submissions

Fixing misplacement of line

Change-Id: Iea11cedd306fe39cb224012c09247817474eea42
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12305
Committed: https://git.mahara.org/mahara/mahara/commit/77656460643321883fd4e49e4fa86358478f9d13
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 77656460643321883fd4e49e4fa86358478f9d13
Author: Dianne Tennent <email address hidden>
Date: Fri Dec 3 11:32:03 2021 +1300

Bug 1952540: Current and Archived submissions

- allow sort by submitted time
- update current submissions csv file column names
- add correct help text to archived id column
- different csv filename for archived and current
- format timestamps

Change-Id: I6aaf3ce250d976e91e5fcea11e8d11c2758168fc
(cherry picked from commit 6ba8f394b58916afd4e766774f5f9be3ab10a23a)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.