Evergreen

Angular Holds Pull List - Download CSV and Print Full Grid missing barcode

Bug #1958265 reported by Terran McCanna
42
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 3.8.1

Bug Description

Evergreen 3.8, Angular Holds Pull List

When attempting to use the Download CSV or Print Full Grid options, the current item barcode number is blank.

(It appears in the grid and also appears if you use the Print Full List button.)

Revision history for this message
Garry Collum (gcollum) wrote :

Also true for the View Holds tab of a bib record.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :

Proposed patch that also fixes it for the View Holds tab for both the Current Item and Requested Item columns:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1958265_holds_list_barcode_print

tags: added: pullrequest
Revision history for this message
Garry Collum (gcollum) wrote :

Works as advertised. A signed-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1958265_holds_list_barcode_print-signoff

tags: added: signedoff
Bill Erickson (berick)
Changed in evergreen:
milestone: none → 3.8.1
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

New branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1958265-ang-holds-grid-barcode-print

1. Includes sign off's.
2. Adds another commit to tweak the barcode display logic to match the grid's display logic. E.g. the "Requested Item" should only populate for item-level holds.

tags: removed: signedoff
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

Works for me! My sign off is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1958265-ang-holds-grid-barcode-print-signoff

tags: added: signedoff
Revision history for this message
Bill Erickson (berick) wrote :

Merged to 3.8 and up. Thanks Terran and Gary!

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.