Problem with annotation feedback and draft feedback

Making the following adjustments will stop the error

/htdocs/artefact/annotation/lib.php
@@ -226,6 +226,7 @@ class ArtefactTypeAnnotation extends ArtefactType {
     protected $artefact; // artefactid of the artefact this annotation is linked to.
     protected $view; // viewid of the view this annotation is linked to.
     protected $lastcontentupdate; // last updated as a datetime.
+ protected $onartefact;

/htdocs/view/view.php
@@ -560,7 +560,9 @@ $smarty = smarty(
 $commentonartefact = param_integer('artefact', null);
 // doublecheck it's a comment on artefact in case is old email
 if ($showcomment) {
- $tmpcomment = new ArtefactTypeComment($showcomment);
+ $artefacttype = get_field('artefact', 'artefacttype', 'id', $showcomment);
+ $classname = generate_artefact_class_name($artefacttype);
+ $tmpcomment = new $classname($showcomment);
     if ($tmpcomment->get('onartefact') && !$commentonartefact) {
         redirect(get_config('wwwroot') . 'view/view.php?id=' . $viewid . '&showcomment=' . $showcomment . '&modal=1&artefact=' . $tmpcomment->get('onartefact'));
     }

But there is still the issue that because the page is shared to the person as a peer they cannot see the annotation block and therefore are not able to make the private annotation feedback public

I had to change a couple of things in the testing scenario:
- Step 3: There appears to be no 'turn on Annotations' setting in Institution settings
- I had to create a new Institution to be able to switch on the 'Allow peers to see portfolio content' setting, which I switched on.

With these settings, at Step 13, I was able to view Person A's page as Person B
But at Step 15, I got the same error - will fix as per above adjustments.

Ah, step 3 would be turn on Smart Evidence

Patch for "main" branch: https://reviews.mahara.org/12381

After fixing this issue, there is another bug:

When I get to step 15, Person B can successfully view the page by clicking on the link in their inbox, without any error messages.

However, when they then click 'Feedback(1)' to view the feedback given on that page, the modal appears, and the page is still visible, but an error message appears behind it above the page content saying 'Access denied'

If you close the modal, and refresh the page, this message disappears.

This has been reported as a separate bug here: https://bugs.launchpad.net/mahara/+bug/1960988

See attachment.

After further investigation, the 'Access denied' error above no longer appears for some reason.

So we have a case where annotations have been enabled for the site, but the institution settings have not been changed to 'Allow peers to see portfolio content'.

In this case, when someone shares their smart evidence portfolio with a peer, their peer cannot see their portfolio content, but they can add feedback to annotations.

At the moment, even for a page, someone can choose to share their portfolio with a peer, even if their institution hasn't allowed peers to see portfolio content.

Perhaps we need to review 'Allow peers to see portfolio content' settings, to remove the option for sharing with peers and remove ability to add feedback as a peer, if this setting hasn't been enabled.

We had decided to not change anything in the behaviour right now as peers who don't have access to the content of a page should not give feedback any way. If someone does need to give feedback and their institution doesn't allow peers to see the page content, they can share the page without the role restriction in place.

This work here only fixes that there is no error message any more.

Reviewed: https://reviews.mahara.org/12381
Committed: https://git.mahara.org/mahara/mahara/commit/f051d53b2a55ed08f33701f864bdd0704f885e06
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit f051d53b2a55ed08f33701f864bdd0704f885e06
Author: Dianne Tennent <email address hidden>
Date: Tue Feb 1 11:20:18 2022 +1300

Bug 1959613: Problem with viewing annotation feedback

Ensure artefact types match when trying to view feedback
on annotations that has been requested to be made public.

Change-Id: Ica3183d96c18c7ec84d85d4658de45efedde867a