Spurious needrestart runs on do-release-upgrade
Bug #1968919 reported by
Robie Basak
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Manual Tests |
New
|
Undecided
|
Unassigned | ||
| needrestart (Ubuntu) |
Won't Fix
|
Undecided
|
Unassigned | ||
| Jammy |
Won't Fix
|
Undecided
|
Unassigned | ||
| ubuntu-release-upgrader (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Jammy |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Expected behaviour: no unnecessary prompts during do-release-upgrade
Actual behaviour: needrestart prompts during do-release-upgrade
Steps to reproduce:
lxc launch ubuntu:impish reproducer
lxc exec reproducer bash
apt-get update && apt-get -y upgrade # needrestart prompts, but that's expected
do-release-upgrade -d # needrestart prompts in the middle of this, and that's unexpected
do-release-upgrade recommends a system reboot after the upgrade is complete. So it's unnecessary to run needrestart and prompt the user for restarts while the upgrade is running.
Related branches
~enr0n/ubuntu-release-upgrader:ubuntu/jammy
Merged
into
ubuntu-release-upgrader:ubuntu/jammy
at
revision dd5d72d62a10a252e6051c405aed3d8332e8bd66
- Steve Langasek: Approve
-
Diff: 2877 lines (+274/-256)133 files modifiedDistUpgrade/DistUpgradeMain.py (+5/-0)
DistUpgrade/DistUpgradeVersion.py (+1/-1)
data/mirrors.cfg (+5/-2)
debian/changelog (+8/-0)
do-release-upgrade (+1/-1)
po/af.po (+2/-2)
po/am.po (+2/-2)
po/an.po (+2/-2)
po/ar.po (+2/-2)
po/ast.po (+2/-2)
po/az.po (+2/-2)
po/be.po (+2/-2)
po/bg.po (+2/-2)
po/bn.po (+2/-2)
po/bo.po (+2/-2)
po/br.po (+2/-2)
po/bs.po (+2/-2)
po/ca.po (+2/-2)
po/ca@valencia.po (+2/-2)
po/ce.po (+2/-2)
po/ceb.po (+2/-2)
po/ckb.po (+2/-2)
po/crh.po (+2/-2)
po/cs.po (+2/-2)
po/csb.po (+2/-2)
po/cv.po (+2/-2)
po/cy.po (+2/-2)
po/da.po (+2/-2)
po/de.po (+2/-2)
po/dv.po (+2/-2)
po/el.po (+2/-2)
po/en_AU.po (+2/-2)
po/en_CA.po (+2/-2)
po/en_GB.po (+2/-2)
po/eo.po (+2/-2)
po/es.po (+2/-2)
po/et.po (+2/-2)
po/eu.po (+2/-2)
po/fa.po (+2/-2)
po/fi.po (+2/-2)
po/fil.po (+2/-2)
po/fo.po (+2/-2)
po/fr.po (+2/-2)
po/fr_CA.po (+2/-2)
po/fur.po (+2/-2)
po/fy.po (+2/-2)
po/ga.po (+2/-2)
po/gd.po (+2/-2)
po/gl.po (+2/-2)
po/gu.po (+2/-2)
po/gv.po (+2/-2)
po/he.po (+2/-2)
po/hi.po (+2/-2)
po/hr.po (+2/-2)
po/hu.po (+2/-2)
po/hy.po (+2/-2)
po/ia.po (+2/-2)
po/id.po (+2/-2)
po/is.po (+2/-2)
po/it.po (+2/-2)
po/ja.po (+2/-2)
po/jv.po (+2/-2)
po/ka.po (+2/-2)
po/kk.po (+2/-2)
po/km.po (+2/-2)
po/kn.po (+2/-2)
po/ko.po (+2/-2)
po/ku.po (+2/-2)
po/ky.po (+2/-2)
po/lb.po (+2/-2)
po/ln.po (+2/-2)
po/lo.po (+2/-2)
po/lt.po (+2/-2)
po/lv.po (+2/-2)
po/mhr.po (+2/-2)
po/mjw.po (+2/-2)
po/mk.po (+2/-2)
po/ml.po (+2/-2)
po/mn.po (+2/-2)
po/mnw.po (+2/-2)
po/mr.po (+2/-2)
po/ms.po (+2/-2)
po/mus.po (+2/-2)
po/my.po (+2/-2)
po/nb.po (+2/-2)
po/nds.po (+2/-2)
po/ne.po (+2/-2)
po/nl.po (+2/-2)
po/nn.po (+2/-2)
po/oc.po (+2/-2)
po/om.po (+2/-2)
po/pa.po (+2/-2)
po/pam.po (+2/-2)
po/pl.po (+2/-2)
po/ps.po (+2/-2)
po/pt.po (+2/-2)
po/pt_BR.po (+2/-2)
po/qu.po (+2/-2)
po/ro.po (+2/-2)
po/ru.po (+2/-2)
po/rw.po (+2/-2)
po/sc.po (+2/-2)
po/sco.po (+2/-2)
po/sd.po (+2/-2)
po/se.po (+2/-2)
po/shn.po (+2/-2)
po/si.po (+2/-2)
po/sk.po (+2/-2)
po/sl.po (+2/-2)
po/sq.po (+2/-2)
po/sr.po (+2/-2)
po/sv.po (+2/-2)
po/szl.po (+2/-2)
po/ta.po (+2/-2)
po/ta_LK.po (+2/-2)
po/te.po (+2/-2)
po/tg.po (+2/-2)
po/th.po (+2/-2)
po/tl.po (+2/-2)
po/tr.po (+2/-2)
po/ubuntu-release-upgrader.pot (+2/-2)
po/ug.po (+2/-2)
po/uk.po (+2/-2)
po/ur.po (+2/-2)
po/uz.po (+2/-2)
po/vi.po (+2/-2)
po/xh.po (+2/-2)
po/zh_CN.po (+2/-2)
po/zh_HK.po (+2/-2)
po/zh_TW.po (+2/-2)
po/zu.po (+2/-2)
utils/demoted.cfg (+1/-0)
utils/demoted.cfg.focal (+1/-0)
| description: | updated |
| tags: | added: fr-2254 |
| tags: | removed: rls-jj-incoming |
| Changed in needrestart (Ubuntu Jammy): | |
| milestone: | none → ubuntu-22.04 |
Revision history for this message
| Andreas Hasenack (ahasenack) wrote | #2 |
Revision history for this message
| Andreas Hasenack (ahasenack) wrote | #3 |
Revision history for this message
| Nick Rosbrook (enr0n) wrote | #4 |
Revision history for this message
| Brian Murray (brian-murray) wrote | #5 |
| Changed in ubuntu-release-upgrader (Ubuntu Jammy): | |
| status: | New → Fix Released |
| Changed in needrestart (Ubuntu Jammy): | |
| status: | New → Won't Fix |
| Changed in needrestart (Ubuntu): | |
| status: | New → Won't Fix |
To post a comment you must log in.
In my test I think I got prompted twice (I said no to restarts as they're unnecessary as I expect to reboot when it's done). The pain of this is that release upgrades usually take a while, so every prompt may mean hours delay in the entire upgrade process since the user might not come back for a while.