Mahara

PHP 8 Compatibility: auth

Bug #1976410 reported by Gold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Gold
Mahara 22.10.0

Bug Description

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the auth dir.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

Gold (gold.catalyst)
Changed in mahara:
importance: Undecided → High
milestone: none → 22.10.0
Revision history for this message
Gold (gold.catalyst) wrote :

Current review:
https://reviews.mahara.org/c/mahara/+/12830

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12830
Committed: https://git.mahara.org/mahara/mahara/commit/ead4bf793c59638dbe6ae692ed923a78f85b6ca2
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit ead4bf793c59638dbe6ae692ed923a78f85b6ca2
Author: Gold <email address hidden>
Date: Tue May 31 14:35:38 2022 +1200

Bug 1976410: PHP8 Compatibility: auth

Updated MemcachedSession::read() to be compatible with what
session_set_save_handler() expects. Also added phpdocblock.

Chaining methods requires the object be returned while add_param()
returns a bool.

Replaces deprecated strftime() with date() and added strftimedaydate1 as
the new string with the date format.

Moved MNET_MDL_ASSIGN_SUBMISSION_MAHARA_PATH into a class for static
analysis discovery.

Change-Id: Idecdd9b2a9d2feede212ae24b6ddf9f3f34b8fb1

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
importance: High → Wishlist
tags: added: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.