Mahara

Wrong email footer

  1. Series 22.04
  2. Bug #1982803
Bug #1982803 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
21.10
Fix Released
High
Unassigned
Mahara 21.10.5
22.04
Fix Released
High
Unassigned
Mahara 22.04.3
22.10
Fix Released
High
Unassigned
Mahara 22.10.0

Bug Description

In bug #800511 we are diverting 'Contact us' messages to institution admins. An additional sentence was added to the email footer though that is also used when a person revokes their access to a portfolio. It then doesn't make sense because they may not be an admin.

Quick fix: Remove the sentence "You are receiving this message because you are an administrator for the institution of which this person is a member." from emailfooter in /htdocs/notification/email/lang/en.utf8/notification.email.php

More elaborate fix: Keep the sentence but only for 'Contact us' messages.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

We'll go with the quick fix for the time being.

To replicate:

1. Create a page.
2. Share the page with another person.
3. Log in as that other person.
4. Remove your own access from the page.
5. Wait for the email to come.

Results:
- Expected: the footer only says "This is an auto-generated notification from Mahara. To update your notification preferences, visit URL

Please do not reply to this message."

- Actual: "You are receiving this message because you are an administrator for the institution of which this person is a member. This is an auto-generated notification from Mahara. To update your notification preferences, visit URL

Please do not reply to this message."

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13012

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13012
Committed: https://git.mahara.org/mahara/mahara/commit/fe7fd91392bb0b9a823becf31840708ba2dd9c46
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit fe7fd91392bb0b9a823becf31840708ba2dd9c46
Author: Doris Tam <email address hidden>
Date: Tue Jul 26 16:28:43 2022 +1200

Bug 1982803: Wrong email footer (quick fix)

Change-Id: I58c26276c3bd30fc47786ffe7413222cd996e3b8

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13027

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13028

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13027
Committed: https://git.mahara.org/mahara/mahara/commit/61ae0559924abe1b996a9aa8a059307d6a174db6
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 61ae0559924abe1b996a9aa8a059307d6a174db6
Author: Doris Tam <email address hidden>
Date: Tue Jul 26 16:28:43 2022 +1200

Bug 1982803: Wrong email footer (quick fix)

Change-Id: I58c26276c3bd30fc47786ffe7413222cd996e3b8
(cherry picked from commit fe7fd91392bb0b9a823becf31840708ba2dd9c46)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/13028
Committed: https://git.mahara.org/mahara/mahara/commit/1faf17fbd94dc48968bd8dd51f93b0457978d05a
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.10_DEV

commit 1faf17fbd94dc48968bd8dd51f93b0457978d05a
Author: Doris Tam <email address hidden>
Date: Tue Jul 26 16:28:43 2022 +1200

Bug 1982803: Wrong email footer (quick fix)

Change-Id: I58c26276c3bd30fc47786ffe7413222cd996e3b8
(cherry picked from commit fe7fd91392bb0b9a823becf31840708ba2dd9c46)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.