Please merge lvm2 2.03.16-1 from Debian unstable.

Attaching patch against Debian unstable. For ease of review, relevant commits
and tags have been pushed to the following repository:

https://code.launchpad.net/~waveform/ubuntu/+source/lvm2/+git/lvm2

Specifically:

* logical/2.03.11-2.1ubuntu4 represents our split-out delta on top of old/debian (2.03.11-2)
* logical/2.03.16-1ubuntu1 represents our rebased delta on top of new/debian (2.03.16-1)
* merge/2.03.16-1ubuntu1 just adds changelog and maintainer changes on top of logical/2.03.16-1ubuntu1

Hence, the following command may produce output useful to the purposes of review:

git range-diff old/debian..logical/2.03.11-2.1ubuntu4 new/debian..logical/2.03.16-1ubuntu1

Test builds are available from ppa:waveform/lvm2 at the following URL:

https://launchpad.net/~waveform/+archive/ubuntu/lvm2

I will sponsor it. Except for some small formatting (patch attached) for the debian/changelog the merge proposal looks good. Having the git repository helped reviewing. Suggestion: Base your branch on https://salsa.debian.org/lvm-team/lvm2 next time.

I removed the trailing spaces from the old debian/changelog entries from Ubuntu and uploaded lvm2 2.03.16-1ubuntu1.

I'm afraid the removal of colons in LP: entries of the changelog is a deliberate tactic by maintainers to prevent launchpad from inadvertently marking things closed when it shouldn't (theoretically, this shouldn't happen if things are targetted correctly to the relevant releases, but this isn't always the case).

On the subject of basing the branch on salsa, I'm not sure how that could work given I'd need to be working with a repo containing two remotes, one the git-ubuntu import (needed to do the initial split because the delta isn't necessarily a monolithic commit; it can consist of several ubuntu versions), and the second from salsa. But the latter's main/master branch cannot match the git-ubuntu import's commit as the commits in the former are generated from the packaging archive.

It would be possible to cherry-pick the rebased delta onto a chosen salsa commit, but that wouldn't affect the output of range-diff, so I'm not seeing how it would improve the ability to review the merge?

This bug was fixed in the package lvm2 - 2.03.16-1ubuntu1

---------------
lvm2 (2.03.16-1ubuntu1) kinetic; urgency=medium

  * Merge from Debian unstable (LP: #1987340). Remaining changes:
    - Lower libdevmapper1.02.1's Depends: dmsetup to a Recommends:. This
      breaks the circular dependency that causes upgrade failures. As dmsetup
      is "Priority: required", this has no other practical consequences.
      (Closes: #586424, LP: #1032823)
    - Add debian/initramfs-tools/lvm2/scripts/init-bottom/lvm2: We cannot
      properly synthesize LVM LV change events with udevadm trigger, so if we
      use LVM, we need to let it finish; otherwise we get missing LV symlinks.
    - Add enable-issue-discards.patch: Enable "issue_discards" option by
      default to trim SSDs when changing PVs. This option has no effect if the
      kernel or the drive does not support trimming, so it's safe to enable by
      default. (Debian #717313)
    - debian/rules:
      - Copy .po file to .pot file for Rosetta (Ubuntu specific).
    - debian/initramfs-tools/lvm2/hooks/lvm2: depend on udev since we ship
      udev rules.
    - Do not start lvm2-monitor in containers (LP: #1576341)
    - Fix patch of systemd-run in 69-lvm-metad.rules
    - d/control: add thin-provisioning-tools build-dep as configure wants it
      around for some checks at build time.
    - Disable lto build. Other distros build it with lto, however Debian has
      an old work around from 2015 for an ABI break. See #791888.
    - Don't build udeb targets.
  * Removed obsolete patches/changes:
    - debian/control: add dmsetup-udeb to libdevmapper1.02.1-udeb recommends.
    - debian/dmsetup-udeb.install: install udev rules in udebs (Debian
      #504341).
      - Ship correct udev rules in lvm2-udeb package.
    - Enable udev-sync in udeb build as it is used by partman when
      partitioning devicemapper devices.
    - Define PYTHON_PREFIX in make.tmpl.in for new ax-python.
  * Removed patches obsoleted/merged by upstream:
    - Fix file mode of debian/initramfs-tools/lvm2/hooks/lvm2 (LP: #1915579)

lvm2 (2.03.16-1) unstable; urgency=medium

  * New upstream release.
  * Disable systemd usage in udeb. (closes: #1015174)

lvm2 (2.03.15-2) unstable; urgency=medium

  * Actually fix filename in lvm2 initamfs-tools integration, fixing
    installation error. (closes: #1014314)

lvm2 (2.03.15-1) unstable; urgency=medium

  * New upstream release.
  * Remove traces of systemd generator.
  * Fix installation of lvmdbusd.
  * Support new udev activation without systemd.

 -- Dave Jones <email address hidden> Mon, 22 Aug 2022 21:35:55 +0100