Mahara

embededurls.php doesn't handle protocolless URLs

  1. Series 21.10
  2. Bug #1992312
Bug #1992312 reported by Gold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
21.04
Fix Released
Medium
Unassigned
Mahara 21.04.7
21.10
Fix Released
Medium
Unassigned
Mahara 21.10.5
22.04
Fix Released
Medium
Unassigned
Mahara 22.04.3
22.10
Fix Released
Medium
Gold
Mahara 22.10.0

Bug Description

I have a db snapshot that has a mix of domains like //example.com and http://example.com.

I was able to replace the http://example.com type URLs but it now reports that there are no more to replace and it doesn't present the form any more.

I still have //example.com URLs as well serving broken images.

We need to be able to present the form in a much more flexible manner.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13195

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 22.10.0
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13195
Committed: https://git.mahara.org/mahara/mahara/commit/e59c3e437c0898f47a89bdc3ffef91d107d6ceaa
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit e59c3e437c0898f47a89bdc3ffef91d107d6ceaa
Author: Gold <email address hidden>
Date: Mon Oct 10 13:46:30 2022 +1300

Bug 1992312: Flexible URL replacements

This should now handle http://example.com, https://example.com, and
protocolless //example.com.

We also now process static_page (site_content) and Wall Posts.

Signed-off-by: Gold <email address hidden>
Change-Id: Ic35b0ab6ee7bd90223666f48597af269f6ecbacf

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13320

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13340

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13321

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13321
Committed: https://git.mahara.org/mahara/mahara/commit/12d2587130cd095a2f279a7b68e2d38fb62912bc
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.04_DEV

commit 12d2587130cd095a2f279a7b68e2d38fb62912bc
Author: Gold <email address hidden>
Date: Mon Oct 10 13:46:30 2022 +1300

Bug 1992312: Flexible URL replacements

This should now handle http://example.com, https://example.com, and
protocolless //example.com.

We also now process static_page (site_content) and Wall Posts.

Signed-off-by: Gold <email address hidden>
Change-Id: Ic35b0ab6ee7bd90223666f48597af269f6ecbacf
(cherry picked from commit e59c3e437c0898f47a89bdc3ffef91d107d6ceaa)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/13340
Committed: https://git.mahara.org/mahara/mahara/commit/0a5c1f4524eb5e214e7359f2ab0c1c34d191fa0f
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.10_DEV

commit 0a5c1f4524eb5e214e7359f2ab0c1c34d191fa0f
Author: Gold <email address hidden>
Date: Mon Oct 10 13:46:30 2022 +1300

Bug 1992312: Flexible URL replacements

This should now handle http://example.com, https://example.com, and
protocolless //example.com.

We also now process static_page (site_content) and Wall Posts.

Signed-off-by: Gold <email address hidden>
Change-Id: Ic35b0ab6ee7bd90223666f48597af269f6ecbacf
(cherry picked from commit e59c3e437c0898f47a89bdc3ffef91d107d6ceaa)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/13320
Committed: https://git.mahara.org/mahara/mahara/commit/56b556990859ca4008e5210eb673858648603a52
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 56b556990859ca4008e5210eb673858648603a52
Author: Gold <email address hidden>
Date: Mon Oct 10 13:46:30 2022 +1300

Bug 1992312: Flexible URL replacements

This should now handle http://example.com, https://example.com, and
protocolless //example.com.

We also now process static_page (site_content) and Wall Posts.

Signed-off-by: Gold <email address hidden>
Change-Id: Ic35b0ab6ee7bd90223666f48597af269f6ecbacf
(cherry picked from commit e59c3e437c0898f47a89bdc3ffef91d107d6ceaa)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13380

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13380
Committed: https://git.mahara.org/mahara/mahara/commit/89c521e250b6be058f98cf7f10c19cd6221488c0
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 89c521e250b6be058f98cf7f10c19cd6221488c0
Author: Gold <email address hidden>
Date: Mon Oct 10 13:46:30 2022 +1300

Bug 1992312: Flexible URL replacements

This should now handle http://example.com, https://example.com, and
protocolless //example.com.

We also now process static_page (site_content) and Wall Posts.

Signed-off-by: Gold <email address hidden>
Change-Id: Ic35b0ab6ee7bd90223666f48597af269f6ecbacf
(cherry picked from commit e59c3e437c0898f47a89bdc3ffef91d107d6ceaa)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.