UVF exception for lsb-3.2

Bug #204594 reported by Matthias Klose
8
Affects Status Importance Assigned to Milestone
lsb (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: lsb

afaiu, we do want hardy to have certified against the current lsb release 3.2, but only have 3.1 packages in hardy. Updated packages are available at http://people.ubuntu.com/~doko/tmp/lsb/.

Related branches

Revision history for this message
Matthias Klose (doko) wrote :

Marc, any feedback about these packages?

Revision history for this message
Matthias Klose (doko) wrote :

$ cat lsb.diffstat
 debian/README.Debian | 36 ++++++++----
 debian/changelog | 54 ++++++++++++++++++
 debian/control | 104 +++++++++++++++++++++++++++++------
 debian/copyright | 1
 debian/po/fi.po | 38 ++++++++++++
 debian/po/ja.po | 53 ++++--------------
 debian/po/pt.po | 38 ++----------
 debian/po/ro.po | 150 +++++++++++++++++++++------------------------------
 debian/rules | 4 +
 init-functions | 22 ++++---
 lsb_release | 44 +++++++++++---
 lsbinstall | 31 +++++++++-
 12 files changed, 362 insertions(+), 213 deletions(-)

Revision history for this message
Steve Langasek (vorlon) wrote :

+ [ -n "$sig" -o "$sig" = 15 -o "$sig" = TERM ] && is_term_sig=yes

Nack on this change; I know it's standard practice for the LSB functions to explode miserably under set -e, but killproc currently does not do this, and init scripts may reasonably rely on a set-e-clean killproc. In fact, there's one init script on my machine, /etc/init.d/atd, which does - the function doesn't behave in an *LSB*-clean manner under set -e, but it does function, so this would be a regression.

Everything else changed here appears to be an improvement, so if you can correct this regression I'm ok with this.

Revision history for this message
Matthias Klose (doko) wrote :
Revision history for this message
Matthias Klose (doko) wrote :
Revision history for this message
Steve Langasek (vorlon) wrote :

The new lsb package has been uploaded and passed through NEW, so closing out this bug.

Changed in lsb:
status: New → Fix Released
Revision history for this message
Onno Benschop (onno-itmaze) wrote :

This patch contains one more idiosyncrasy, namely, on line 90 and 91:

        /bin/pidof -o %PPID $1
        status="$?"

I suspect that this needs to become:

        /bin/pidof -o %PPID $1 || status="$?"

Also, the changelog does not refer to this bug report in any way, which I understood to be a requirement for a patch.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Debdiff attached, implementing Onno's changes.

Matthias, should the lsb package be merged with Debian for Intrepid before applying this change? As it's only 2 lines changing, it may not matter...

Thanks,
:-Dustin

Revision history for this message
Martin Pitt (pitti) wrote :

Ah, already applied in current intrepid.

Changed in lsb:
status: Fix Released → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.